Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bond between Functional Group and structure disappears after adding Functional Group again #2229

Closed
Zhirnoff opened this issue Feb 15, 2023 · 0 comments · Fixed by #2230 or #2231
Closed

Bond between Functional Group and structure disappears after adding Functional Group again #2229

Zhirnoff opened this issue Feb 15, 2023 · 0 comments · Fixed by #2230 or #2231
Assignees
@St-Permiakov
Labels
bug Priority: High
Milestone
Ketcher 2.8.0-rc.4

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 15, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add 'Benzene' and two 'Single Bond' on it
  3. Select any 'Functional Group' abbreviation and add to top of the each bond
  4. Select same 'Functional Group' abbreviation or another and add to existed

Actual behavior
Bond between Functional Group and structure disappears after adding Functional Group again

Expected behavior
Last added Functional Group replaces the existing one and the bond remains in place

Screenshots

2023-02-15_22h51_59.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.3

Additional context
Maybe this issue could affect: #2195

#184100466
@Zhirnoff Zhirnoff added the bug label Feb 15, 2023
@Zhirnoff Zhirnoff added this to the Refined Backlog milestone Feb 15, 2023
@Nitvex Nitvex assigned St-Permiakov and unassigned Nitvex Feb 16, 2023
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#2229 - Bond between Functional Group and structure disappears after …
5d20ad8 
…adding Functional Group again
@St-Permiakov St-Permiakov mentioned this issue Feb 16, 2023
Merged
@Nitvex Nitvex linked a pull request Feb 16, 2023 that will close this issue
#2229: Bond between Functional Group and structure disappears after adding Functional Group again #2230
Merged
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#2229 - rename pos0/pos1
5d7e595
St-Permiakov pushed a commit that referenced this issue Feb 16, 2023
#2229 - more clear logic when replacing group
5d70500
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
c736f77 
…dding Functional Group again (#2230)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
7f18a60 
…dding Functional Group again (#2230)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
@St-Permiakov St-Permiakov mentioned this issue Feb 16, 2023
Merged
@St-Permiakov St-Permiakov linked a pull request Feb 16, 2023 that will close this issue
Backmerge: #2229: Bond between Functional Group and structure disappears after adding Functional Group again #2231
Merged
St-Permiakov added a commit that referenced this issue Feb 16, 2023
@St-Permiakov
#2229: Bond between Functional Group and structure disappears after a…
67a0af0 
…dding Functional Group again (#2230) (#2231)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
@Zhirnoff Zhirnoff mentioned this issue Feb 21, 2023
Closed
ansivgit pushed a commit that referenced this issue Feb 22, 2023
@St-Permiakov @ansivgit
#2229: Bond between Functional Group and structure disappears after a…
fd99a90 
…dding Functional Group again (#2230) (#2231)

* #1990 - Detect if group is attached to smth + get attachment atom

* #2229 - Bond between Functional Group and structure disappears after adding Functional Group again

* #2229 - rename pos0/pos1

* #2229 - more clear logic when replacing group

---------

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@St-Permiakov St-Permiakov

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.8.0-rc.4
3 participants
@St-Permiakov @Nitvex @Zhirnoff