Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to add a bond to a Functional Group by Bond Tool #2257

Closed
Zhirnoff opened this issue Feb 21, 2023 · 4 comments · Fixed by #2261 or #2494
Closed

Unable to add a bond to a Functional Group by Bond Tool #2257

Zhirnoff opened this issue Feb 21, 2023 · 4 comments · Fixed by #2261 or #2494
Assignees
@yuleicul
Milestone
Ketcher 2.10.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 21, 2023 •
edited
Loading

Steps to Reproduce

  1. Open Ketcher
  2. Add any Functional Group on canvas
  3. Select 'Single Bond'
  4. Attach to Functional Group
    Note: also reproduce with 'Chain'

Actual behavior
Unable add a bond to a Function Group

Expected behavior
Able add a bond to a Function Group

Screenshots

2023-02-21_14h52_22.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.3

Additional context
Related issue: #2229
@Zhirnoff Zhirnoff added the bug label Feb 21, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.9.0-rc.1 milestone Feb 21, 2023
St-Permiakov pushed a commit that referenced this issue Feb 22, 2023
#2257 - Unable add a bond to a Function Group
b9e2aa5
@St-Permiakov St-Permiakov mentioned this issue Feb 22, 2023
Merged
@St-Permiakov St-Permiakov assigned St-Permiakov and unassigned Nitvex Feb 22, 2023
KonstantinEpam23 pushed a commit that referenced this issue Mar 6, 2023
@St-Permiakov
#2257 - Unable add a bond to a Function Group (#2261)
282dd66 
Co-authored-by: Stanislav Permiakov <stanislav_permiakov@epam.com>
@yuleicul
Copy link
Collaborator

yuleicul commented Mar 7, 2023

Please take a look at this @St-Permiakov

scrnli_3_7_2023_11-05-01.AM.mp4

KonstantinEpam23 added a commit that referenced this issue Mar 10, 2023
@KonstantinEpam23
Revert "#2257 - Unable add a bond to a Function Group (#2261)"
3a93328 
This reverts commit 282dd66.
KonstantinEpam23 added a commit that referenced this issue Mar 10, 2023
@KonstantinEpam23
Revert "#2257 - Unable add a bond to a Function Group (#2261)" (#2319)
5dccb44 
This reverts commit 282dd66.
@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Mar 10, 2023 •
edited
Loading

The code that was merged seems to break the chain tool when combined with this PR: #2079
We need to address this issue separately

@yuleicul
Copy link
Collaborator

yuleicul commented Mar 14, 2023 •
edited
Loading

One clarification, what's the right behavior when I'm trying to add a bond to a terminal functional group, like
image

@yuleicul
Copy link
Collaborator

One clarification, what's the right behavior when I'm trying to add a bond to a terminal functional group, like image

As discussed in the async meeting, the answer is to add a new bond that connects two functional groups.

@yuleicul yuleicul changed the title Unable add a bond to a Function Group Unable to add a bond to a Functional Group by Bond Tool Mar 14, 2023
yuleicul added a commit that referenced this issue Mar 15, 2023
@yuleicul
#2257 - Refactor fromBondAddition
d7aff95
yuleicul added a commit that referenced this issue Mar 15, 2023
@yuleicul
#2257 - Refactor fromBondAddition and update usage
e116759
yuleicul added a commit that referenced this issue Mar 15, 2023
@yuleicul
#2257 - Fix bond tool to add a bond on functional group
00812f0
@yuleicul yuleicul mentioned this issue Mar 15, 2023
Closed
yuleicul added a commit that referenced this issue Mar 15, 2023
@yuleicul
#2257 - Update tests for fromBondAddition
e45891e
@yuleicul yuleicul linked a pull request Mar 15, 2023 that will close this issue
#2257 Unable to add a bond to a functional group by bond tool #2351
Closed
@yuleicul yuleicul removed a link to a pull request Mar 15, 2023
#2257 Unable to add a bond to a functional group by bond tool #2351
Closed
@yuleicul yuleicul linked a pull request Mar 15, 2023 that will close this issue
#2257 Unable to add a bond to a functional group by bond tool #2351
Closed
yuleicul added a commit that referenced this issue Apr 19, 2023
@yuleicul
\#2257 - Refactor fromBondAddition and update usage
c5cfdbe
yuleicul added a commit that referenced this issue Apr 19, 2023
@yuleicul
#2257 - Fix bond tool to add a bond on functional group
07594a4
yuleicul added a commit that referenced this issue Apr 19, 2023
@yuleicul
#2257 - Update tests for fromBondAddition
c5c9874
yuleicul added a commit that referenced this issue Apr 19, 2023
@yuleicul
#2257 - Fix findItem to skip clicked functional group
ebf8900
@yuleicul yuleicul mentioned this issue Apr 19, 2023
Merged
@yuleicul yuleicul linked a pull request Apr 19, 2023 that will close this issue
#2257 Unable to add a bond to a functional group by bond tool #2494
Merged
yuleicul added a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 - Fix Bond Tool to link FG when starting on nothing
35711bb
yuleicul added a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 - Fix Bond Tool linking Salts&Solvents
9842a53
yuleicul added a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 - Fix FG to link multiple atoms
03bdfaf
yuleicul added a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 - Add types or comments
c6c40a9
yuleicul added a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 - Fix ci
92d2ad4
KonstantinEpam23 pushed a commit that referenced this issue Apr 20, 2023
@yuleicul
#2257 Unable to add a bond to a functional group by bond tool (#2494)
382e2ea 
* \#2257 - Refactor fromBondAddition and update usage

* #2257 - Fix bond tool to add a bond on functional group

* #2257 - Update tests for `fromBondAddition`

* #2257 - Fix findItem to skip clicked functional group

* #2257 - Fix Bond Tool to link FG when starting on nothing

* #2257 - Fix Bond Tool linking Salts&Solvents

* #2257 - Fix FG to link multiple atoms

* #2257 - Add types or comments

* #2257 - Fix ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
None yet
Projects
None yet
Milestone
Ketcher 2.10.0-rc.1
5 participants
@St-Permiakov @yuleicul @Nitvex @Zhirnoff @KonstantinEpam23