Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple bond editing changes bond types to all selected bonds #2246

Closed
mwojcikowski opened this issue Feb 20, 2023 · 5 comments · Fixed by #2352
Closed

Multiple bond editing changes bond types to all selected bonds #2246

mwojcikowski opened this issue Feb 20, 2023 · 5 comments · Fixed by #2352
Assignees
Labels

Comments

@mwojcikowski
Copy link
Collaborator

Steps to Reproduce

  1. Select multiple bonds with mixed bond order.
    image

  2. Enter "edit" menu of the bonds. Optional: change reaction center or topology value.
    image

  3. Save changes. Bond order has changed for entire selection.
    image

The same happens if you enter edit with single bond:
image

Expected behavior
In edit bond window the bond order is unselected if mixed order bonds were selected. Saving changes should not change bond orders unless explicitly changed.

Ketcher version
v2.7.1

@Zhirnoff
Copy link
Collaborator

Hi @mwojcikowski thank you for using Ketcher! What exactly you mean "Bond order has changed for entire selection"?

@mwojcikowski
Copy link
Collaborator Author

mwojcikowski commented Feb 20, 2023

Hi @Zhirnoff,
What I meant is that the bonds are converted to single or double, depending on the bond you click to edit. Compare the images in 1 vs 3. Bond order = bond type in this case.

Hopefully this image is clearer. Top one is when you click on single bond. Bottom when on doulbe.
image

@mwojcikowski
Copy link
Collaborator Author

Other software handles such issue, that the bond order is not set at all (or set to an empty value).
image

@Zhirnoff
Copy link
Collaborator

@mwojcikowski Thanks for the more detailed information. We will try to fix this behavior in future releases.

@Zhirnoff Zhirnoff changed the title Multiple bond selection changes all bonds order Multiple bond selection changes all selected bonds Feb 20, 2023
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Feb 20, 2023

Steps to Reproduce

  1. Open Ketcher
  2. Add structure on canvas ketcher (42).zip
  3. Highlight the top of the structure with a double bond and single bonds
  4. Double click on Double bond
  5. Select 'Topology'=Ring and press Apply

Actual behavior
Topology is assigned to all selected bonds, but single bonds became double

Expected behavior
Topology is assigned to all selected bonds, single bonds have not changed

Note: This behavior is due to the fact that during multiple selection and further editing in the 'Bond Properties' window, the type of bond is already selected, which is applied to the multiselect.
Only the properties that were changed in the dialog box to be applied, and everything else left unmodified.
If a property is different for some atoms, then display "" (empty string) and do not change it after press Apply
If property is the same for all atoms, then display the value.
Related issue: #2145

Screenshots

2023-02-20_20h13_10.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.8.0-rc.3

Additional context

@Zhirnoff Zhirnoff changed the title Multiple bond selection changes all selected bonds Multiple bond editing changes bond types to all selected bonds Feb 20, 2023
@KonstantinEpam23 KonstantinEpam23 added this to the Ketcher 2.9.0-rc.1 milestone Feb 21, 2023
KonstantinEpam23 pushed a commit that referenced this issue Apr 4, 2023
…2352)

* #2246 Multiple bond editing changes bond types to all selected bonds

* #2246 returned function castAtomPropToType
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants