#2246 Multiple bond editing changes bond types to all selected bonds #2352
Conversation
| @@ -155,6 +155,7 @@ export const bond = { | |||
| type: { | |||
| title: 'Type', | |||
| enum: [ | |||
| '', | |||
There was a problem hiding this comment.
@AnastasiiaPlyako can you please comment on this
There was a problem hiding this comment.
Discussed with Konstantin. This field allows you to have an empty line when selected bonds have different types. The same logic is realized for atoms. https://github.com/epam/ketcher/blob/master/packages/ketcher-react/src/script/ui/data/schema/struct-schema.js#L62
| @@ -232,7 +232,7 @@ function fromBondType(type, stereo) { | |||
| ) | |||
| return caption | |||
| } | |||
| throw Error('No such bond caption') | |||
| return '' | |||
There was a problem hiding this comment.
Could you please clarify, why this is needed? :)
There was a problem hiding this comment.
When types in bonds are different, we put an empty string. Method fromBondType return the corresponding type from the variable bondCaptionMap. But the empty line doesn't correspond to any of the types bondCaptionMap and throws the error, which stops the execution of the code.
KonstantinEpam23
deleted the
#2246-multiple-bond-editing-changes-bond-types-to-all-selected-bonds
branch
closes #2246