Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Erase" tool for macromolecules editor #2370

Closed
KsenMs opened this issue Mar 16, 2023 · 1 comment · Fixed by #3217
Closed

"Erase" tool for macromolecules editor #2370

KsenMs opened this issue Mar 16, 2023 · 1 comment · Fixed by #3217
Assignees
@Nitvex
Labels
feature request Macromolecules [PE] Basic drawing operations
Milestone
Macromolecules Mi...

Comments

@KsenMs
Copy link
Collaborator

KsenMs commented Mar 16, 2023 •
edited
Loading

  1. There is an “Erase” button
  2. "Eraser" tool allows to remove monomers and bonds displayed on the canvas:
  • If user has selected an item/items on the canvas and then clicks "Erase", this selected item/items disappear(s)
  • If a user clicks on "Eraser" button and then click on a specific monomer, this monomer + all the bonds linked to it disappear from the canvas
  • If a user clicks on "Eraser" button and then click on a specific bond, this bond disappears from the canvas
@KsenMs KsenMs mentioned this issue Mar 31, 2023
Open
@KsenMs KsenMs changed the title "Erase" tool - draft "Erase" tool Apr 20, 2023
@KsenMs KsenMs removed the draft label Apr 20, 2023
@OlZhur OlZhur added this to the Polymer Editor MVP milestone Apr 28, 2023
rrodionov91 added a commit that referenced this issue Aug 30, 2023
@rrodionov91
#2370 - "Erase" tool
4bf7ff7 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
@rrodionov91 rrodionov91 mentioned this issue Aug 30, 2023
Merged
9 tasks
@rrodionov91 rrodionov91 changed the title "Erase" tool "Erase" tool for macromolecules editor Aug 30, 2023
rrodionov91 added a commit that referenced this issue Aug 30, 2023
@rrodionov91
#2370 - "Erase" tool
59df6df 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Aug 30, 2023
@rrodionov91
#2370 - "Erase" tool
2a0faec 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Aug 30, 2023
@rrodionov91
#2370 - "Erase" tool
b42346a 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Aug 31, 2023
@rrodionov91
#2370 - "Erase" tool
aeadd9c 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Sep 1, 2023
@rrodionov91
#2370 - "Erase" tool
c095b72 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Sep 1, 2023
@rrodionov91
#2370 - "Erase" tool
81ada9d 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
rrodionov91 added a commit that referenced this issue Sep 1, 2023
@rrodionov91
#2370 - "Erase" tool
a440132 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 4, 2023
@rrodionov91
#2370 - "Erase" tool
5e452d1 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 8, 2023
@rrodionov91
#2370 - "Erase" tool
6bb4129 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 8, 2023
@rrodionov91
#2370 - "Erase" tool
2d9f84e 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 12, 2023
@rrodionov91
#2370 - "Erase" tool
0716c44 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 13, 2023
@rrodionov91
#2370 - "Erase" tool
19b56df 
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
- added rootDir to tsconfig of core package
rrodionov91 added a commit that referenced this issue Sep 13, 2023
@rrodionov91
#2370 - erase tool for macromolecules editor (#3217)
ada37e4 
#2370 - "Erase" tool
#2360 - "Select" tool

- added select and erase tools
- implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render
@MartaWilliams
Copy link
Collaborator

Tested

2023-10-24_12h10_07.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
feature request Macromolecules [PE] Basic drawing operations
Projects
None yet
Milestone
Macromolecules Milestone 1
Development

Successfully merging a pull request may close this issue.

#2370 - erase tool for macromolecules editor epam/ketcher
4 participants
@Nitvex @MartaWilliams @KsenMs @OlZhur