#2370 - erase tool for macromolecules editor #3217
Conversation
rrodionov91
changed the title
rrodionov91
force-pushed
the
2370-erase-tool
branch
3 times, most recently
from
2a0faec
to
b42346a
Compare
| await page.getByText('Tza').click(); | ||
|
|
||
| // Create 4 peptides on canvas | ||
| await page.mouse.click(300, 300); |
There was a problem hiding this comment.
We should avoid using magic numbers
| await page.getByText('Tza').click(); | ||
|
|
||
| // Create 4 peptides on canvas | ||
| await page.mouse.click(300, 300); |
There was a problem hiding this comment.
We should avoid using magic numbers
| await page.getByText('Tza').click(); | ||
|
|
||
| // Create 4 peptides on canvas | ||
| await page.mouse.click(300, 300); |
There was a problem hiding this comment.
We should avoid using magic numbers
rrodionov91
force-pushed
the
2370-erase-tool
branch
5 times, most recently
from
a440132
to
5e452d1
Compare
| await bondTwoMonomers(page, peptide3, peptide4); | ||
|
|
||
| await page.screenshot({ | ||
| path: 'tests/Macromolecule-editor/screenshots/erase-tool.png', |
There was a problem hiding this comment.
I propose to use a function takeEditorScreenshot. It automatically creates screenshot of canvas area and generates the screenshot name. (may be it requires some modification for Macromolecules)
| Description: Rectangle Selection Tool | ||
| */ | ||
|
|
||
| await turnOnMacromoleculesEditor(page); |
There was a problem hiding this comment.
This function is, most likely, supposed to be used in beforeEach block as the tests are always for MacroMolecules
| await page.mouse.click(500, 200); | ||
|
|
||
| // Get 4 peptides locators | ||
| const peptides = await page.getByText('Tza').locator('..'); |
There was a problem hiding this comment.
i propose to create a separate function for making some structure and reuse it across tests. Then it will be simpler to replace it, once we have import from file feature
| } | ||
|
|
||
| export async function selectRectangleSelectionTool(page: Page) { | ||
| const bondToolButton = page.locator(`button[title*="select-rectangle"]`); |
There was a problem hiding this comment.
My proposal is to avoid using locators by title and use page.getByTestId
There was a problem hiding this comment.
All tools buttons are done in that way. Let's keep it in one style for now.
| import { expect, Page } from '@playwright/test'; | ||
|
|
||
| export async function turnOnMacromoleculesEditor(page: Page) { | ||
| await expect(page.getByTestId('PolymerToggler')).toBeVisible(); |
There was a problem hiding this comment.
I propose to maintain common style and use kebab-case for ids
| @@ -51,6 +49,20 @@ export class CoreEditor { | |||
| this.events.selectMonomer.add((monomer) => this.onSelectMonomer(monomer)); | |||
| this.events.selectPreset.add((preset) => this.onSelectRNAPreset(preset)); | |||
| this.events.selectTool.add((tool) => this.onSelectTool(tool)); | |||
| const renderersEvents: ToolEventHandlerName[] = [ | |||
There was a problem hiding this comment.
Let's move it to separate file. Most likely, we will have a lot of different events.
rrodionov91
force-pushed
the
2370-erase-tool
branch
from
5e452d1
to
6bb4129
Compare
rrodionov91
force-pushed
the
2370-erase-tool
branch
from
6bb4129
to
2d9f84e
Compare
- added an ability to add peptides on canvas and move by drag n drop
rrodionov91
force-pushed
the
2370-erase-tool
branch
from
2d9f84e
to
0716c44
Compare
#2360 - "Select" tool - added select and erase tools - implemented DrawingEntitiesManager and RenderersManager which controls entities parameters changes and render - added rootDir to tsconfig of core package
rrodionov91
force-pushed
the
2370-erase-tool
branch
from
0716c44
to
19b56df
Compare
Closes #2370
Closes #2360
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name