Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkeys for atoms don't work on Functional Groups and Salts abbreviations #2423

Closed
Zhirnoff opened this issue Mar 28, 2023 · 0 comments · Fixed by #2580
Closed

Hotkeys for atoms don't work on Functional Groups and Salts abbreviations #2423

Zhirnoff opened this issue Mar 28, 2023 · 0 comments · Fixed by #2580
Assignees
@AnastasiiaPlyako
Labels
bug
Milestone
Ketcher 2.12.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add Functional Groups and Salts and Solvents abbreviations on canvas
  3. Press 'O' or 'N' hotkey on Functional Groups and Salts and Solvents abbreviations on canvas

Actual behavior
Nothing happens

Expected behavior
Oxygen or Nitrogen atoms replace a Functional Groups and Salts and Solvents abbreviations on canvas

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.5
@Zhirnoff Zhirnoff added the bug label Mar 28, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.10.0-rc.1 milestone Mar 28, 2023
@Nitvex Nitvex assigned AnastasiiaPlyako and unassigned Nitvex Apr 18, 2023
AnastasiiaPlyako added a commit that referenced this issue May 8, 2023
@AnastasiiaPlyako
#2423 fix hotkey for functional groups
f12f007
@AnastasiiaPlyako AnastasiiaPlyako linked a pull request May 8, 2023 that will close this issue
#2423 Hotkeys for atoms don't work on Functional Groups and Salts abbreviations #2580
Merged
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2423-hotkeys-for-atoms-dont-work-on-funct…
58b2a79 
…ional-groups-and-salts-abbreviations

# Conflicts:
#	packages/ketcher-react/src/script/editor/tool/atom.ts
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2423 moved logic with sgroup to handleHotkeysOverItem
6bc7b7e
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2423-hotkeys-for-atoms-dont-work-on-funct…
d196d68 
…ional-groups-and-salts-abbreviations

# Conflicts:
#	packages/ketcher-react/src/script/ui/state/hotkeys.ts
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2423 fix imports
7f66001
@gairon gairon assigned gairon and unassigned gairon May 23, 2023
AnastasiiaPlyako added a commit that referenced this issue May 29, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2423-hotkeys-for-atoms-dont-work-on-funct…
440be93 
…ional-groups-and-salts-abbreviations
AnastasiiaPlyako added a commit that referenced this issue May 29, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2423-hotkeys-for-atoms-dont-work-on-funct…
0e6b619 
…ional-groups-and-salts-abbreviations

# Conflicts:
#	packages/ketcher-react/src/script/ui/state/handleHotkeysOverItem.ts
AnastasiiaPlyako added a commit that referenced this issue May 31, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2423-hotkeys-for-atoms-dont-work-on-funct…
9a4ca97 
…ional-groups-and-salts-abbreviations
Nitvex pushed a commit that referenced this issue Jun 8, 2023
@AnastasiiaPlyako
#2423 Hotkeys for atoms don't work on Functional Groups and Salts abb…
8de0ba6 
…reviations (#2580)

* #2423 fix hotkey for functional groups

* #2423 moved logic with sgroup to handleHotkeysOverItem

* #2423 fix imports

* #2513 fix bug with SRU polymer

* #2513 move logic to Atom Tool

* #2513 replace functionalGroup by hovering

* #2513 fix issue when atom doesn't exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaPlyako AnastasiiaPlyako

Labels
bug
Projects
None yet
Milestone
Ketcher 2.12.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2423 Hotkeys for atoms don't work on Functional Groups and Salts abbreviations epam/ketcher
5 participants
@gairon @Nitvex @Zhirnoff @AnastasiiaPlyako @KonstantinEpam23