Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure playwright with github actions #2513

Closed
Nitvex opened this issue Apr 21, 2023 · 0 comments · Fixed by #2514
Closed

Configure playwright with github actions #2513

Nitvex opened this issue Apr 21, 2023 · 0 comments · Fixed by #2514
Assignees
@AnastasiiaPlyako
Labels
feature request
Milestone
Ketcher 2.12.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Apr 21, 2023 •
edited
Loading

Background
Now e2e tests are located in private Gitlab repo. This is supposed to be changed in order to run e2e tests in Github

Solution
Acceptance criteria:
– Transfer a couple of stable e2e tests from Gitlab to Github actions
– Setup Github Action for e2e tests to be run on every PR
– Build must not be performed multiple times
– Screenshot tests must be reproducible on both local and CI environment.

Additional links
For playwright configs you may refer: https://playwright.dev/docs/ci-intro#github-actions
For screenshot tests it is proposed to use docker on both environments to get the same screenshots.
@Nitvex Nitvex added this to the Ketcher 2.11.0-rc.1 milestone Apr 21, 2023
@Nitvex Nitvex assigned Nitvex and Konstantin1996 and unassigned Nitvex Apr 21, 2023
@Konstantin1996 Konstantin1996 mentioned this issue Apr 27, 2023
Merged
@Nitvex Nitvex linked a pull request Apr 27, 2023 that will close this issue
Configure playwright with github actions #2514
Merged
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 add docker and snapshot for linux
73c5f41
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change playwright workflow by adding docker
4463e91
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
Merge branch 'master' into #2513-configure-playwright-with-github-act…
be4e39c 
…ions

# Conflicts:
#	package-lock.json
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change runs on
b0e1247
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 delete install in autotest
1c730ed
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
228da26
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
72cc7db
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
e52328b
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
7377437
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
792e816
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
6245611
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
1a5c52f
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
2cd4192
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
0c9f52f
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
fa17858
AnastasiiaPlyako added a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2513 change autotests docker
6c6d451
AnastasiiaPlyako added a commit that referenced this issue May 18, 2023
@AnastasiiaPlyako
#2513 change version for ubuntu
357aa47
AnastasiiaPlyako added a commit that referenced this issue May 18, 2023
@AnastasiiaPlyako
#2513 update read me
a6c522c
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2513 if tests are failed
bd771f7
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2513 if tests are failed
ecadb8e
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2513 failed tests
a261303
AnastasiiaPlyako added a commit that referenced this issue May 23, 2023
@AnastasiiaPlyako
#2513 failed tests
265357b
AnastasiiaPlyako added a commit that referenced this issue May 24, 2023
@AnastasiiaPlyako
#2513 failed tests
418e8a6
AnastasiiaPlyako added a commit that referenced this issue May 24, 2023
@AnastasiiaPlyako
#2513 update read me, add new command for autotests
9ad39bf
AnastasiiaPlyako added a commit that referenced this issue May 24, 2023
@AnastasiiaPlyako
#2513 comment firefox
7ae41ab
AnastasiiaPlyako added a commit that referenced this issue May 24, 2023
@AnastasiiaPlyako
#2513 fix one command in read me
3cc07e9
AnastasiiaPlyako added a commit that referenced this issue May 24, 2023
@AnastasiiaPlyako
#2513 align config with ketcher-autotests
6727a3d
AnastasiiaPlyako added a commit that referenced this issue May 29, 2023
@AnastasiiaPlyako
#2513 fix bug with SRU polymer
cbd3b59
AnastasiiaPlyako added a commit that referenced this issue May 31, 2023
@AnastasiiaPlyako
#2513 move logic to Atom Tool
f80b6b6
AnastasiiaPlyako added a commit that referenced this issue Jun 1, 2023
@AnastasiiaPlyako
#2513 replace functionalGroup by hovering
d7fd4df
AnastasiiaPlyako added a commit that referenced this issue Jun 1, 2023
@AnastasiiaPlyako
#2513 fix issue when atom doesn't exist
ff76641
AnastasiiaPlyako added a commit that referenced this issue Jun 6, 2023
@AnastasiiaPlyako
#2513 delete container for frontend, use host
c516457
AnastasiiaPlyako added a commit that referenced this issue Jun 6, 2023
@AnastasiiaPlyako
#2513 correct test
b23dfc3
AnastasiiaPlyako added a commit that referenced this issue Jun 6, 2023
@AnastasiiaPlyako
#2513 install only chrome
9a4d2f7
AnastasiiaPlyako added a commit that referenced this issue Jun 6, 2023
@AnastasiiaPlyako
#2513 update read me
0dbb2fe
Nitvex pushed a commit that referenced this issue Jun 8, 2023
@AnastasiiaPlyako
#2423 Hotkeys for atoms don't work on Functional Groups and Salts abb…
8de0ba6 
…reviations (#2580)

* #2423 fix hotkey for functional groups

* #2423 moved logic with sgroup to handleHotkeysOverItem

* #2423 fix imports

* #2513 fix bug with SRU polymer

* #2513 move logic to Atom Tool

* #2513 replace functionalGroup by hovering

* #2513 fix issue when atom doesn't exist
Nitvex pushed a commit that referenced this issue Jun 16, 2023
@Konstantin1996 @AnastasiiaPlyako
Configure playwright with github actions (#2514)
ba34c19 
* - added yml configuration file

* updated yml command

* added autotest repo

* added ls

* changed path

* Install Playwright Browsers after going to ketcher-autotests

* added logs and changed scripts

* moved env upper

* added correct folder

* added workflow_run, removed console.log

* added update:snapshots

* specify snapshotPathTemplate

* - removed test-results from .gitignore, created ideal snapshots

* trying to set working-directory

* - removed working directory

* updated snapshotPathTemplate

* added ketcher-api removed snapshots

* added ketcher-canvas

* updated snapshots

* added new version of repo

* added screenshots

* ketcher-canvas single test with single golden screenshot

* - added new test file ketcher-canvas-ci

* - changed test a bit

* - only one test

* removed repo again

* again new repo

* - changed command to npx

* - added golden screenshots

* - uncomment tests

* added missed golden screenshots

* skip flaky tests

* increased timeout, unskip tests

* - removed extra folders

* - removed package @playwright/test from ketcher package

* renamed Install playwright browsers and playwright/test and add npm install -D @playwright/test

* - used npm ci instead npm install -D @playwright/test

* moved CI false into env option in playwright

* removed extra from package-lock.json

* #2513 add docker and snapshot for linux

* #2513 change playwright workflow by adding docker

* #2513 change runs on

* #2513 delete install in autotest

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change autotests docker

* #2513 change version for ubuntu

* #2513 update read me

* #2513 update read me

* #2513 update read me

* #2513 if tests are failed

* #2513 if tests are failed

* #2513 failed tests

* #2513 failed tests

* #2513 failed tests

* #2513 update read me, add new command for autotests

* #2513 comment firefox

* #2513 fix one command in read me

* #2513 align config with ketcher-autotests

* #2513 delete container for frontend, use host

* #2513 correct test

* #2513 install only chrome

* #2513 update read me

* update read me, delete extra variable in package.json

* add ignored tests

* check ignore tests

* check ignore tests

* check ignore tests

* fix env

* fix env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check env

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* check url

* delete snapshots for windows and mac

* update read me

---------

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
Co-authored-by: AnastasiiaPlyako <anastasia_plyako@epam.com>
AnastasiiaPlyako added a commit that referenced this issue Jun 19, 2023
@AnastasiiaPlyako
Merge pull request #2776 from epam/#2513-docker-playwright-report-CI-CD
068adcc 
#2513 add report on CI / CD
@AnastasiiaPlyako AnastasiiaPlyako mentioned this issue Jul 11, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaPlyako AnastasiiaPlyako

Labels
feature request
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.12.0-rc.1
Development

Successfully merging a pull request may close this issue.

Configure playwright with github actions epam/ketcher
4 participants
@Konstantin1996 @Nitvex @AnastasiiaPlyako @KonstantinEpam23