Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight colors for Simple Objects do not match the new design #2679

Closed
Zhirnoff opened this issue May 25, 2023 · 2 comments · Fixed by #2706, #2711, #2955 or #3051
Closed

Highlight colors for Simple Objects do not match the new design #2679

Zhirnoff opened this issue May 25, 2023 · 2 comments · Fixed by #2706, #2711, #2955 or #3051
Assignees
@StarlaStarla
Labels
bug
Milestone
Ketcher 2.14.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add Simple objects on canvas (e.g. Shape Ellips, Shape Rectangle, Shape Line)
  3. Add Benzene ring and any atoms
  4. Select all and look at selection colors

Actual behavior
Highlight colors for Simple Objects do not match the new design

Expected behavior
Highlight colors for Simple Objects is match the new design

Screenshots
2023-05-25_14h14_44

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.11.0-rc.1
@Zhirnoff Zhirnoff added the bug label May 25, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.11.0-rc.2 milestone May 25, 2023
@Nitvex Nitvex linked a pull request May 30, 2023 that will close this issue
#2681 – Calculate CIP: stereolabels appears under structure; #2679 – Highlight colors for Simple Objects do not match the new design; #2683 – Missing circles to expand reaction arrows #2706
Merged
@Nitvex Nitvex mentioned this issue May 30, 2023
Merged
Nitvex added a commit that referenced this issue May 30, 2023
@Nitvex
#2681 – Calculate CIP: stereolabels appears under structure; #2679 – …
23c6702 
…Highlight colors for Simple Objects do not match the new design; #2683 – Missing circles to expand reaction arrows (#2706)

* #2681 – Calculate CIP: stereolabels appears under structure

* #2683 – Missing circles to expand reaction arrows
Nitvex added a commit that referenced this issue May 30, 2023
@Nitvex
Backmerge: #2681 – Calculate CIP: stereolabels appears under structure;
3514c24 
#2679 – Highlight colors for Simple Objects do not match the new design; #2683 – Missing circles to expand reaction arrows (#2706)

* #2681 – Calculate CIP: stereolabels appears under structure

* #2683 – Missing circles to expand reaction arrows
@Nitvex Nitvex mentioned this issue May 30, 2023
Merged
Nitvex added a commit that referenced this issue May 30, 2023
@Nitvex
Backmerge: #2681 – Calculate CIP: stereolabels appears under structure;
43e3710 
#2679 – Highlight colors for Simple Objects do not match the new design; #2683 – Missing circles to expand reaction arrows (#2706) (#2711)

* #2681 – Calculate CIP: stereolabels appears under structure

* #2683 – Missing circles to expand reaction arrows
@Zhirnoff
Copy link
Collaborator Author

  1. The color is lighter than that of templates and atoms.
    2023-05-30_18h51_08

  2. When selecting and hovering over an Ellipse or Rectangle, the inner area is highlighted.
    2023-05-30_19h08_59

  3. Points for changing the scale are filled with highlights, which makes them less noticeable.
    2023-05-30_19h07_41
    2023-05-30_19h09_32

@Zhirnoff Zhirnoff reopened this May 30, 2023
@KonstantinEpam23 KonstantinEpam23 removed their assignment May 31, 2023
StarlaStarla added a commit that referenced this issue Jul 25, 2023
@StarlaStarla
#2679 Highlight colors for Simple Objects do not match the new design
607aafd
@StarlaStarla StarlaStarla linked a pull request Jul 25, 2023 that will close this issue
#2679 - Highlight colors for Simple Objects do not match the new design #2955
Merged
8 tasks
@rrodionov91 rrodionov91 mentioned this issue Jul 25, 2023
Merged
8 tasks
StarlaStarla added a commit that referenced this issue Jul 28, 2023
@StarlaStarla
#2679 add auto tests and unit tests
c4ca59c
StarlaStarla added a commit that referenced this issue Aug 2, 2023
@StarlaStarla
Merge pull request #2955 from epam/2679-highlight-colors-for-simple-o…
f725f61 
…bjects-do-not-match-the-new-design

#2679 - Highlight colors for Simple Objects do not match the new design
@ViktoriaTkacheva
Copy link
Collaborator

When selecting and hovering over a word, the word is completely filled and the text disappears

656a5503-3db0-49b5-bddf-511964031cf6

3d37acbf-40a6-4ed6-96e8-b09d5816f548

StarlaStarla added a commit that referenced this issue Aug 7, 2023
@StarlaStarla
#2679 revert changes for text
c44bfa6
@StarlaStarla StarlaStarla linked a pull request Aug 7, 2023 that will close this issue
#2679 Highlight colors for Simple Objects do not match the new design #3051
Merged
8 tasks
Zhirnoff added a commit that referenced this issue Aug 7, 2023
@Zhirnoff
Merge pull request #3051 from epam/2679-highlight-colors-for-simple-o…
21c7427 
…bjects-do-not-match-the-new-design

#2679 Highlight colors for Simple Objects do not match the new design
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug
Projects
None yet
Milestone
Ketcher 2.14.0-rc.1
5 participants
@StarlaStarla @Nitvex @Zhirnoff @KonstantinEpam23 @ViktoriaTkacheva