#2679 - Highlight colors for Simple Objects do not match the new design #2955
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlaStarla
changed the title
rrodionov91
requested changes
Jul 26, 2023
Comment on lines
194
to
200
| getHoverPathStyle(path: any, render: Render, type: boolean) { | ||
| if (type) { | ||
| return path.attr(render.options.hoverStyle); | ||
| } else { | ||
| return path.attr({ ...render.options.hoverStyle, fill: '#fff' }); | ||
| } | ||
| } |
There was a problem hiding this comment.
Not sure that "type" is a good name here. Could you please change it or describe what is it?
Comment on lines
+248
to
+258
| tfx(Math.min(point[0].x, point[1].x) - scaleFactor / 8), | ||
| tfx(Math.min(point[0].y, point[1].y) - scaleFactor / 8), | ||
| tfx( | ||
| Math.max(point[0].x, point[1].x) - | ||
| Math.min(point[0].x, point[1].x) + | ||
| scaleFactor / 4, | ||
| ), | ||
| tfx( | ||
| Math.max(point[0].y, point[1].y) - | ||
| Math.min(point[0].y, point[1].y) + | ||
| scaleFactor / 4, |
There was a problem hiding this comment.
If you understood what "tfx" is please rename it
There was a problem hiding this comment.
I found there is a separate Jira for this #2675, so I just skip it for now
…ghlight-colors-for-simple-objects-do-not-match-the-new-design
StarlaStarla
requested review from
AleksandraSmolianinova,
Ustianskii,
Vehemen,
Zhirnoff,
y-holik,
MartaWilliams and
krakmielepam
as code owners
|
Bug is fixed |
Zhirnoff
approved these changes
Jul 31, 2023
rrodionov91
approved these changes
Aug 2, 2023
StarlaStarla
deleted the
2679-highlight-colors-for-simple-objects-do-not-match-the-new-design
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2679
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name