Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rotation Tool: non-selected end of the selected bond should be the rotation center #2750

Closed
yuleicul opened this issue Jun 7, 2023 · 0 comments · Fixed by #2666
Closed

Rotation Tool: non-selected end of the selected bond should be the rotation center #2750

yuleicul opened this issue Jun 7, 2023 · 0 comments · Fixed by #2666
Assignees
@yuleicul
Labels
bug feature request
Milestone
Ketcher 2.12.0-rc.1

Comments

@yuleicul
Copy link
Collaborator

yuleicul commented Jun 7, 2023

One end of selected bond is selected, while the other end is non-selected, in this situation, the rotation center should be the non-selected end.

image
@yuleicul yuleicul self-assigned this Jun 7, 2023
@Nitvex Nitvex added this to the Ketcher 2.12.0-rc.1 milestone Jun 7, 2023
@yuleicul yuleicul mentioned this issue Jun 8, 2023
Merged
yuleicul added a commit that referenced this issue Jun 8, 2023
@yuleicul
#2750 - Fix unselected end of the selected bond to be the center
0a0a034
Nitvex pushed a commit that referenced this issue Jun 9, 2023
@yuleicul
#2584 #2750 - Selection tool: add flip and delete buttons & Rotation …
4d491ab 
…Tool: non-selected end of the selected bond should be the rotation center (#2666)

* #2584 - Refactor: add type declarations to external module 'subscription'

* #2584 - Add new reducer for floating tools

* #2584 - Add new component FloatingTools

* #2584 - Update position of floating tools

* #2584 - Fix position to be correct after scrolling and zooming

* #2584 - Fix rotation box to be rerendered after flipping

* #2584 - Fix floating tools to update position when scrolling

* #2584 - Update erase button's icon to delete

* #2584 - Remove transform tool group from left toolbar

* #2584 - Rename handlePos to rotateHandlePosition

* #2584 - Expose a public method to handle scrolling

* #2584 - Make handleCenter private

* #2584 - Change Vec2 to {x, y}

* #2584 - Remove raphael2view

* #2584 - Fix ci

* #2584 - Fix ci after merging

* #2584 - Support to flip multi structures as a whole

* #2584 - Support to flip rxnArrow

* #2584 - Support to flip texts and rxnPluses

* #2584 - Remove functionality of flipping one single bond

* #2584 - Remove unused code

* #2584 - Fix flip positions of texts

* #2584 - Decouple action generators and UI

* #2750 - Fix unselected end of the selected bond to be the center

* #2584 - Avoid importing type from ui to editor (code review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
bug feature request
Projects
None yet
Milestone
Ketcher 2.12.0-rc.1
2 participants
@yuleicul @Nitvex