-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2584 #2750 - Selection tool: add flip and delete buttons & Rotation Tool: non-selected end of the selected bond should be the rotation center #2666
Conversation
packages/ketcher-react/src/script/ui/views/toolbars/FloatingTools/FloatingTools.container.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/ui/views/toolbars/ToolbarGroupItem/ToolbarGroupItem.tsx
Outdated
Show resolved
Hide resolved
017b5c7
to
278cc9d
Compare
packages/ketcher-react/src/script/ui/views/toolbars/FloatingTools/FloatingTools.tsx
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/ui/views/toolbars/FloatingTools/FloatingTools.container.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/ui/state/floatingTools/index.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/ui/views/components/StructEditor/StructEditor.jsx
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/editor/tool/rotate-controller.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/editor/tool/rotate-controller.ts
Outdated
Show resolved
Hide resolved
packages/ketcher-react/src/script/editor/tool/rotate-controller.ts
Outdated
Show resolved
Hide resolved
Hi @yuleicul! I believe we do need to support flipping arrows for reactions (especially since we already support rotating them) I would propose to support flipping arrows in the scope of this pull request, unless it is hard to implement. |
@yuleicul thanks for your work, it is a good solution. |
@kaluginserg Thanks for your review! Actually, the reason why I close two issues in this PR is because the two issues have overlapped code, if I open separate PRs, it may be hard to resolve conflicts. But anyway, thanks for your kind reminder, I'll pay more attention next time. |
Closes #2584
Closes #2750
What's new
Floating buttons
New flip support
more details: