Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing warning message when pasting copied structure via the "Paste" button #2790

Closed
Zhirnoff opened this issue Jun 24, 2023 · 0 comments · Fixed by #2868
Closed

Missing warning message when pasting copied structure via the "Paste" button #2790

Zhirnoff opened this issue Jun 24, 2023 · 0 comments · Fixed by #2868
Assignees
@Inga-Vishnivetskaia
Labels
bug Priority: High
Milestone
Ketcher 2.13.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jun 24, 2023 •
edited by Inga-Vishnivetskaia
Loading

Steps to Reproduce

  1. Build Ketcher with iFrame
  2. Copy to clipboard any structure
  3. Press button 'Paste' on top toolbar

Note: the bug is not reproduced on the rc stand and prod.

Actual behavior
No warning message is displayed when press 'Paste' button.

2023-06-24_11h23_29.mp4

Expected behavior
After clicking the "Paste" button, a warning message:
'Error Message
Your browser doesn't allow pasting clipboard content via button. Please use shortcut instead.'
and Ctrl/Cmd + V for paste
should appear to inform the user about pasting options.

Screenshot (1209)

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.11.0-rc.4 iFrame

#185465468
@Zhirnoff Zhirnoff added the bug label Jun 24, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.13.0-rc.1 milestone Jun 24, 2023
@Nitvex Nitvex assigned Inga-Vishnivetskaia and unassigned Nitvex Jul 3, 2023
Inga-Vishnivetskaia added a commit that referenced this issue Jul 5, 2023
@Inga-Vishnivetskaia
#2790-move-ErrorModal-to-ketcher-react
b67bb78
@Inga-Vishnivetskaia Inga-Vishnivetskaia linked a pull request Jul 5, 2023 that will close this issue
#2790 Missing warning message when pasting copied structure via the "Paste" button #2868
Merged
Inga-Vishnivetskaia added a commit that referenced this issue Jul 5, 2023
@Inga-Vishnivetskaia
#2790-rename-ErrorModal-to-InfoModal-and-change-modal-text
6ab178d
Inga-Vishnivetskaia added a commit that referenced this issue Jul 10, 2023
@Inga-Vishnivetskaia
#2790-remove-copy-cut-paste-Modal-from-client-to-ketcher-react
a42c813
Inga-Vishnivetskaia added a commit that referenced this issue Jul 14, 2023
@Inga-Vishnivetskaia
#2790-add-e2e-test-for-paste-action
d2fbb3c
@Inga-Vishnivetskaia Inga-Vishnivetskaia mentioned this issue Jul 14, 2023
Open
Inga-Vishnivetskaia added a commit that referenced this issue Jul 14, 2023
@Inga-Vishnivetskaia
#2790-update-e2e-test-paste-action
0467b43
Nitvex pushed a commit that referenced this issue Jul 14, 2023
@Inga-Vishnivetskaia
#2790 Missing warning message when pasting copied structure via the "…
8ca2465 
…Paste" button (#2868)

* 2790-move-ErrorModal-to-ketcher-react

* 2790-rename-ErrorModal-to-InfoModal-and-change-modal-text

* remove arrow function

* 2790-remove-copy-cut-paste-Modal-from-client-to-ketcher-react

* 2790-rebase-branch-fix-prettier

* 2790-fix-after-rebase

* add unit tests for InfoModal dialog

* 2790-fix-lint-errors-for-unit-tests

* 2790-fix-lint-errors-screen-container-in-unit-tests

* #2790-add-e2e-test-for-paste-action

* #2790-update-e2e-test-paste-action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Inga-Vishnivetskaia Inga-Vishnivetskaia

Labels
bug Priority: High
Projects
None yet
Milestone
Ketcher 2.13.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2790 Missing warning message when pasting copied structure via the "Paste" button epam/ketcher
3 participants
@Nitvex @Zhirnoff @Inga-Vishnivetskaia