#2790 Missing warning message when pasting copied structure via the "Paste" button #2868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Inga-Vishnivetskaia
commented
Jul 5, 2023
•
Inga-Vishnivetskaia
commented
- ErroModal component moved to "ketcher-react", refactored in order to have the correct a11y provided by Dialog "ketcher-react" component, Copy / Cut / Paste modals are triggered by the library and not controlled by Client anymore
- Added more descriptive modal body for Paste
- Added Unit tests
- Added e2e tests
yuleicul
reviewed
Jul 6, 2023
Nitvex
reviewed
Jul 6, 2023
yuleicul
approved these changes
Jul 7, 2023
Inga-Vishnivetskaia
force-pushed
the
#2790-missing-warning-message-when-pasting-copied-structure-via-the-paste-button
branch
from
f4ca4bb
to
5c35648
Compare
Inga-Vishnivetskaia
force-pushed
the
#2790-missing-warning-message-when-pasting-copied-structure-via-the-paste-button
branch
from
a42c813
to
b53d0f6
Compare
Inga-Vishnivetskaia
requested review from
AleksandraSmolianinova,
Ustianskii,
Vehemen and
Zhirnoff
as code owners
Nitvex
approved these changes
Jul 14, 2023
Nitvex
reviewed
Jul 14, 2023
...tests/Structure-Creating-&-Editing/Actions-With-Structures/Paste-Action/paste-action.spec.ts
Outdated
Show resolved
Hide resolved
Nitvex
reviewed
Jul 14, 2023
...tests/Structure-Creating-&-Editing/Actions-With-Structures/Paste-Action/paste-action.spec.ts
Outdated
Show resolved
Hide resolved
AleksandraSmolianinova
approved these changes
Jul 14, 2023
Nitvex
deleted the
#2790-missing-warning-message-when-pasting-copied-structure-via-the-paste-button
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.