Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Movement of structure ceases when it reaches the boundaries of canvas, requiring the consistent movement of mouse to continue its motion #2909

Closed
Zhirnoff opened this issue Jul 10, 2023 · 2 comments · Fixed by #3342
Closed

Movement of structure ceases when it reaches the boundaries of canvas, requiring the consistent movement of mouse to continue its motion #2909

Zhirnoff opened this issue Jul 10, 2023 · 2 comments · Fixed by #3342
Assignees
@nanoblit
Labels
bug
Milestone
Ketcher 2.16.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add two Benzene rings on canvas
  3. Select one of them and move to the edges of canvas

Actual behavior
The movement of the structure occurs in shaking when the user brings the structure close to the edge of the canvas, and in order for the structure to continuously move beyond the canvas boundaries, continuous mouse movements are required.

Expected behavior
When the user brings the structure close to the edge of the canvas, smooth and continuous movement should be ensured instead of shaking motion. Additionally, the structure should be able to move beyond the canvas boundaries without the need for continuous mouse movements.

Screenshots

2023-07-10_19h00_31.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.12.0-rc.3
@Zhirnoff Zhirnoff added the bug label Jul 10, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.13.0-rc.1 milestone Jul 10, 2023
@Zhirnoff Zhirnoff changed the title Structure stop moving when reach boundaries of canvas and need for continuous mouse movements for continue movement The movement of the structure ceases when it reaches the boundaries of the canvas, requiring the consistent movement of the mouse to continue its motion Jul 10, 2023
@Zhirnoff Zhirnoff changed the title The movement of the structure ceases when it reaches the boundaries of the canvas, requiring the consistent movement of the mouse to continue its motion Movement of structure ceases when it reaches the boundaries of canvas, requiring the consistent movement of mouse to continue its motion Jul 10, 2023
@NatalliaHutovich NatalliaHutovich self-assigned this Jul 24, 2023
@Nitvex Nitvex removed their assignment Jul 27, 2023
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Aug 9, 2023

Test cases are written by me.

NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - use selected area bounds in resize canvas action while mousemove
c4658a2
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - use destination vector mapping in resize canvas action while …
78a4106 
…mousemove
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - move moveSelection to canvas extension
f9c117f
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - set lower scroll multiplier
d791b34
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - add continuuis moving for select area if mouse leave client area
1052275
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - start continuous selection movement on client area wrapper mo…
902c918 
…useleave
NatalliaHutovich added a commit that referenced this issue Aug 15, 2023
@NatalliaHutovich
#2909 - add offset & timer interval constants
86a8107
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - remove scroll when mouse reaches screen edges
93d6645
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - remove resize canvas while move selection on canva
789dd86
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - use step for moveSelected
077e011
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - set lower distance between selected box and edge of canvas
d7beefb
@NatalliaHutovich NatalliaHutovich mentioned this issue Aug 17, 2023
Closed
8 tasks
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - fix import
ee651c9
NatalliaHutovich added a commit that referenced this issue Aug 17, 2023
@NatalliaHutovich
#2909 - fix unit test
7d259e5
@Nitvex Nitvex assigned Nitvex and nanoblit and unassigned NatalliaHutovich Aug 21, 2023
@Nitvex Nitvex removed their assignment Aug 25, 2023
nanoblit added a commit that referenced this issue Sep 19, 2023
@nanoblit
#2909 - Add smooth movement
d0745e7
@nanoblit nanoblit linked a pull request Sep 19, 2023 that will close this issue
#2909 - movement of structure ceases when it reaches the boundaries of canvas requiring the consistent movement of mouse to continue its motion #3342
Merged
9 tasks
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Sep 20, 2023 •
edited
Loading

Pre-tested. Bug is fixed. But there are still some comments that will be fixed in another task

2023-09-20_13h33_30.mp4

nanoblit added a commit that referenced this issue Sep 20, 2023
@nanoblit
#2909 - Refactor code
2fee521
nanoblit added a commit that referenced this issue Sep 20, 2023
@nanoblit
#2909 - Make canvas movement framerate independent
f7b57a5
nanoblit added a commit that referenced this issue Sep 20, 2023
@nanoblit
#2909 - Refactor
e6effdb
nanoblit added a commit that referenced this issue Sep 21, 2023
@nanoblit
#2909 - Remove scrollMultiplier
d019e8a
nanoblit added a commit that referenced this issue Sep 22, 2023
@nanoblit
#2909 - Add type for previousMouseMoveEvent
5f750bb
Nitvex pushed a commit that referenced this issue Sep 25, 2023
@nanoblit
#2909 - movement of structure ceases when it reaches the boundaries o…
4d84438 
…f canvas requiring the consistent movement of mouse to continue its motion (#3342)

* #2909 - Add smooth movement

* #2909 - Refactor code

* #2909 - Make canvas movement framerate independent

* #2909 - Refactor

* #2909 - Remove scrollMultiplier

* #2909 - Add type for previousMouseMoveEvent
@Zhirnoff Zhirnoff mentioned this issue Sep 26, 2023
Closed
SashaGraves pushed a commit that referenced this issue Sep 28, 2023
@nanoblit @SashaGraves
#2909 - movement of structure ceases when it reaches the boundaries o…
63ec1b8 
…f canvas requiring the consistent movement of mouse to continue its motion (#3342)

* #2909 - Add smooth movement

* #2909 - Refactor code

* #2909 - Make canvas movement framerate independent

* #2909 - Refactor

* #2909 - Remove scrollMultiplier

* #2909 - Add type for previousMouseMoveEvent
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanoblit nanoblit

Labels
bug
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.1
4 participants
@nanoblit @Nitvex @NatalliaHutovich @Zhirnoff