Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make any atom and atom list part of the Atom properties #3340

Closed
AlexanderSavelyev opened this issue Sep 19, 2023 · 1 comment · Fixed by #3368
Closed

Make any atom and atom list part of the Atom properties #3340

AlexanderSavelyev opened this issue Sep 19, 2023 · 1 comment · Fixed by #3368

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Sep 19, 2023

Background
Current atom properties window does not allow to view/change atom if it is any atom or atom list

Solution

  • Create additional "Atom type" (dropdown) inside the Atom properties with possible options:

    • Single
    • List
    • Special
  • For atom type Single the menu atom properties should be the same as current

    • new icon "edit" should be added near the "Label" (see screenshot below)
    • if press "edit" then the dialog "Periodic Table" should be opened and user should be able to select atom
    • The selection "Single", "List", "Not List" should be removed while displaying "Periodic Table"
  • For the atom type List , Label and Number should be hided and

    • new items "List" (input field) and "edit" icon
    • "Not list (checkbox)" should be added
    • "List" should be disabled for the change, List can be changed by pressing "Edit" icon (see screenshot below). If "Edit" is pressed, then the dialog "Periodic Table" and use should be able to choose the List elements
    • The selection "Single", "List", "Not List" should be removed while displaying "Periodic Table"
    • If create a customQuery from the "List" atom type, then the selected "List" should be converted into comma-separated atom numbers. "Not list" should be converted to "and" not atoms. E.g. N,C,O -> #7,#6,#8 , NOT N,C,O -> !#7;!#6;!#8
  • For the atom type Special , Label and Number should be hidden and

    • new item "Special" (input field) and "edit" icon
    • by pressing "edit" icon (see screenshot below) the "Extended Table" dialog and use should be able to choose the special atom type
    • user should be able to change Special type directly in input field. The validation should be: one of the elements from "Extended Table"
    • If create a customQuery from the "Special" then it should be empty for all input values (just take all other query properties)
      image
  • Creating customQuery should convert atom type to Special/ Any Atom (display on canvas and edit properties if disable customQuery back)

@AlexanderSavelyev AlexanderSavelyev added this to the Refined Backlog milestone Sep 19, 2023
@AlexanderSavelyev AlexanderSavelyev changed the title Make atom list part of the Atom query properties Make any atom and atom list part of the Atom properties Sep 22, 2023
@AKZhuk AKZhuk linked a pull request Sep 27, 2023 that will close this issue
9 tasks
AKZhuk added a commit that referenced this issue Sep 27, 2023
AKZhuk added a commit that referenced this issue Sep 29, 2023
- Add unique key for AtomLabel component
Nitvex pushed a commit that referenced this issue Oct 2, 2023
* #3340 - Make any atom and atom list part of the Atom properties

* #3340 - Make any atom and atom list part of the Atom properties
- Update e2e snapshots

* #3340 - Make any atom and atom list part of the Atom properties
- Add unique key for AtomLabel component

* Merge branch 'master' into 3340-make-any-atom-and-atom-list-part-of-the-atom-properties
- Fix pr comment

* Merge branch 'master' into 3340-make-any-atom-and-atom-list-part-of-the-atom-properties
- Fix failed tests
@ViktoriaTkacheva
Copy link
Collaborator

Preview. No comments

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants