Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autotests: add tests for missed test cases based on done tickets for SMARTS #3581

Closed
urszula-gawlowska opened this issue Nov 16, 2023 · 0 comments · Fixed by #3710
Closed

Comments

@urszula-gawlowska
Copy link
Collaborator

urszula-gawlowska commented Nov 16, 2023

List of SMARTS tickets which need autotests

Ketcher side issues:

  1. Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3393 Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
  2. When adding all Atom Properties from the "Query specific" section, some edges of the Template "Cycloheptane" move to the side #3424 When adding all Atom Properties from the "Query specific" section, some edges of the Template "Cycloheptane" move to the side
    together with
    Bond is shifted when list of atoms (at least 3) or few general atom's properties are specified at label near to the next atom #3508 Bond is shifted when list of atoms (at least 3) or few general atom's properties are specified at label near to the next atom
  3. Improve query attributes view on canvas  #3327 Improve query attributes view on canvas
  4. Warnings appear while saving any structure as Daylight SMARTS #3431 Warnings appear while saving any structure as Daylight SMARTS (the same from Indigo side: Indigo should return warning for some attributes  Indigo#1325) (check if/why warning appeas for atom query specific attribute - ring membership - confirm with Aleksandr Savelev if this is correct)
  5. All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3459 All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists (add test case for general atom properties + one smart specific to the atom properties spec file)
  6. Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query. #3445 Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query (add tests for checking converting attributes to custom query - preview)
  7. When insert a smarts with two query groups after inserting smarts with one query group error appear #3408 When insert a smarts with two query groups after inserting smarts with one query group error appear
  8. When you save atom in ket format with substitutionCount greater then 6 , it is impossible to open it #3397 When you save atom in ket format with substitutionCount greater then 6 , it is impossible to open it
  9. Save atom properties for atom list in ket format #3387 Save atom properties for atom list in ket format (add checking SMARTS with atom list)
  10. Update customQuery for bonds using topology #3372 Update customQuery for bonds using topology
  11. When you replace an atom with the selected one from Periodic table, additional symbols appear next to it. #3362 When you replace an atom with the selected one from Periodic table, additional symbols appear next to it.
  12. Make any atom and atom list part of the Atom properties #3340 Make any atom and atom list part of the Atom properties (add atom List and Special to atom-properties.spec.ts)
  13. Add empty options for atom charges and isotops #3339 Add empty options for atom charges and isotops (add test cases for edge values)
  14. New S-Group type Query component level grouping #3338 New S-Group type Query component level grouping (add tests for checking displaying and functionalities + saving SMARTS file wtih S-Group)
  15. Add bond custom query field #3328 Add bond custom query field (add tests for checking functionality, displaying on canvas, preview, validation for not empty field, check saving at KET file)

Indigo side issues:
16. epam/Indigo#1358 Error while loading [!#6,!#7,!#8] smarts
17. epam/Indigo#1332 Aromatic atom list is not recognized in SMARTS query (saving and loading + test case with custom query with list of atoms in lowercase)
18. epam/Indigo#1321 When saving a structure with set up Implicit H count and any other atom attribute then an error appears (add to the query-specific-attributes.spec.ts test case for more then one attribute set up)
19. epam/Indigo#1316 SMARTS saver miss component level grouping (add that test case for saving and loading?)
20. epam/Indigo#1281 Support SMARTS "or unspecified" bond property in custom queries (???)
21. epam/Indigo#1254 SMARTS with component-level grouping saved without '()' (add some tests for saving and loading with different types of grouping?)
22. epam/Indigo#1252 SMARTS loader load grouped components as separate molecules (???)

@urszula-gawlowska urszula-gawlowska self-assigned this Nov 16, 2023
Nitvex pushed a commit that referenced this issue Jan 4, 2024
…ets for smarts (#3710)

* adding test for checking  pasting as SMARTS feature

* adding few tests for visual check

* adding screenshots for tests from visual-check spec

* adding tests for checking warnings - covering with test cases ticket number 3431

* adding tests to cover ticket 3459 and 3445

* removing unnecessary import

* adding tests to cover ticket 3397 and 3408

* removing unnecessary import

* adding tests to cover 3387, 3372, 3362 and 3340

* adding tests to cover ticket 3339

* adding tests to cover tickets 3338 and 3328

* adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252

* - code refactoring

* - working on comments;
- added 2 expected snapshots

* - code refactoring

* - change name of function

* - code refactoring

---------

Co-authored-by: Urszula Gawlowska <urszula.gawlowska@epam.com>
Co-authored-by: Zhirnoff <mikhail_zhirnov@epam.com>
Zhirnoff added a commit that referenced this issue Jan 4, 2024
…ets for smarts (#3710)

* adding test for checking  pasting as SMARTS feature

* adding few tests for visual check

* adding screenshots for tests from visual-check spec

* adding tests for checking warnings - covering with test cases ticket number 3431

* adding tests to cover ticket 3459 and 3445

* removing unnecessary import

* adding tests to cover ticket 3397 and 3408

* removing unnecessary import

* adding tests to cover 3387, 3372, 3362 and 3340

* adding tests to cover ticket 3339

* adding tests to cover tickets 3338 and 3328

* adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252

* - code refactoring

* - working on comments;
- added 2 expected snapshots

* - code refactoring

* - change name of function

* - code refactoring

---------

Co-authored-by: Urszula Gawlowska <urszula.gawlowska@epam.com>
Co-authored-by: Zhirnoff <mikhail_zhirnov@epam.com>
@Zhirnoff Zhirnoff closed this as completed Jan 5, 2024
Zhirnoff added a commit that referenced this issue Feb 3, 2024
…ets for smarts (#3710)

* adding test for checking  pasting as SMARTS feature

* adding few tests for visual check

* adding screenshots for tests from visual-check spec

* adding tests for checking warnings - covering with test cases ticket number 3431

* adding tests to cover ticket 3459 and 3445

* removing unnecessary import

* adding tests to cover ticket 3397 and 3408

* removing unnecessary import

* adding tests to cover 3387, 3372, 3362 and 3340

* adding tests to cover ticket 3339

* adding tests to cover tickets 3338 and 3328

* adding tests to cover indigo issues 1358, 1332, 1321, 1316, 1281 and 1252

* - code refactoring

* - working on comments;
- added 2 expected snapshots

* - code refactoring

* - change name of function

* - code refactoring

---------

Co-authored-by: Urszula Gawlowska <urszula.gawlowska@epam.com>
Co-authored-by: Zhirnoff <mikhail_zhirnov@epam.com>
rrodionov91 pushed a commit that referenced this issue Feb 5, 2024
- add tests for missed test cases based on done tickets for smarts (#3710)

Co-authored-by: Urszula Gawlowska <urszula.gawlowska@epam.com>
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment