Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3393

Closed
AKZhuk opened this issue Oct 4, 2023 · 0 comments · Fixed by #3433 or #3496
Closed

Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3393

AKZhuk opened this issue Oct 4, 2023 · 0 comments · Fixed by #3433 or #3496
Assignees
@AKZhuk
Labels
epic: smarts feature request
Milestone
Ketcher 2.16.0-rc.2

Comments

@AKZhuk
Copy link
Collaborator

AKZhuk commented Oct 4, 2023 •
edited
Loading

Background
When user pastes smarts/smiles string(via paste shortcut/paste from clipboard window) indigo doesn't know how is should proceed it like smiles or smarts.

Solution

  • Add new keyboard shortcut "ctrl+alt+V"(command+option+V for macOS) for pasting as SMARTS. If user paste structure via new shortcut, then Ketcher should load input structure as SMARTS
  • backend should return original format by using "original_format": "$format" (where $format is one of the currently support content types)

Tickets for Indigo:
epam/Indigo#1355
epam/Indigo#1357
epam/Indigo#1360
@AKZhuk AKZhuk self-assigned this Oct 4, 2023
@AlexanderSavelyev AlexanderSavelyev added this to the Refined Backlog milestone Oct 4, 2023
@AliaksandrDziarkach AliaksandrDziarkach mentioned this issue Oct 4, 2023
Closed
@AKZhuk AKZhuk changed the title Add popup with options “paste as Smiles” and “paste as Smarts” Add popup with options “paste as Smiles” Oct 5, 2023
@AKZhuk AKZhuk changed the title Add popup with options “paste as Smiles” Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS Oct 11, 2023
AKZhuk added a commit that referenced this issue Oct 12, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
fbbf4a3
@AKZhuk AKZhuk linked a pull request Oct 12, 2023 that will close this issue
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3433
Merged
9 tasks
AKZhuk added a commit that referenced this issue Oct 16, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
765b603
AKZhuk added a commit that referenced this issue Oct 16, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
883a9df 
 - Skip input-format option in standalone mode
AKZhuk added a commit that referenced this issue Oct 17, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
4d8a758 
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 17, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
d32211c 
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 17, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
62408ef 
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 18, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
e306750 
 - Add input-format option in standalone mode
AKZhuk added a commit that referenced this issue Oct 18, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
ae12bff 
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 19, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
a8956d1 
 - Update reaction related snapshots
AKZhuk added a commit that referenced this issue Oct 19, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
147db7b 
 - Migrate to Indigo 1.15.0-dev.4 in-browser
AKZhuk added a commit that referenced this issue Oct 20, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
e82ebd8 
 - Migrate to Indigo 1.15.0-dev.4 in-browser
- Update snapshots
AKZhuk added a commit that referenced this issue Oct 23, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
f0c982a 
 - Migrate to Indigo 1.15.0-rc.1 in-browser
 - Update snapshots
AKZhuk added a commit that referenced this issue Oct 24, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
23301df 
 - Fix pr comments
AKZhuk added a commit that referenced this issue Oct 24, 2023
@AKZhuk
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
cf9be1a 
 - Fix pr comments part 2
Nitvex pushed a commit that referenced this issue Oct 24, 2023
@AKZhuk @Zhirnoff
#3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS (#…
6827730 
…3433)

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Migrate to Indigo 1.15.0-rc.1 in-browser
 - Update snapshots

* - updated snapshot

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Fix pr comments

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Fix pr comments part 2

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
@AKZhuk AKZhuk closed this as completed Oct 24, 2023
AKZhuk added a commit that referenced this issue Oct 24, 2023
@AKZhuk
Backmerge: #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting…
91d9c02 
… as SMARTS
@AKZhuk AKZhuk mentioned this issue Oct 24, 2023
Merged
9 tasks
Nitvex pushed a commit that referenced this issue Oct 25, 2023
@AKZhuk
Backmerge: #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting…
6e52786 
… as SMARTS (#3496)
@urszula-gawlowska urszula-gawlowska mentioned this issue Nov 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AKZhuk AKZhuk

Labels
epic: smarts feature request
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.2
3 participants
@AlexanderSavelyev @AKZhuk @Nitvex