Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3393

Closed
AKZhuk opened this issue Oct 4, 2023 · 0 comments · Fixed by #3433 or #3496
Closed

Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS #3393

AKZhuk opened this issue Oct 4, 2023 · 0 comments · Fixed by #3433 or #3496

Comments

@AKZhuk
Copy link
Collaborator

AKZhuk commented Oct 4, 2023

Background
When user pastes smarts/smiles string(via paste shortcut/paste from clipboard window) indigo doesn't know how is should proceed it like smiles or smarts.

Solution

  • Add new keyboard shortcut "ctrl+alt+V"(command+option+V for macOS) for pasting as SMARTS. If user paste structure via new shortcut, then Ketcher should load input structure as SMARTS
  • backend should return original format by using "original_format": "$format" (where $format is one of the currently support content types)

Tickets for Indigo:
epam/Indigo#1355
epam/Indigo#1357
epam/Indigo#1360

@AKZhuk AKZhuk self-assigned this Oct 4, 2023
@AlexanderSavelyev AlexanderSavelyev added this to the Refined Backlog milestone Oct 4, 2023
@AKZhuk AKZhuk changed the title Add popup with options “paste as Smiles” and “paste as Smarts” Add popup with options “paste as Smiles” Oct 5, 2023
@AKZhuk AKZhuk changed the title Add popup with options “paste as Smiles” Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS Oct 11, 2023
@AKZhuk AKZhuk linked a pull request Oct 12, 2023 that will close this issue
9 tasks
AKZhuk added a commit that referenced this issue Oct 16, 2023
 - Skip input-format option in standalone mode
AKZhuk added a commit that referenced this issue Oct 17, 2023
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 17, 2023
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 17, 2023
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 18, 2023
 - Add input-format option in standalone mode
AKZhuk added a commit that referenced this issue Oct 18, 2023
 - Migrate to Indigo 1.15.0-dev.3 in-browser
AKZhuk added a commit that referenced this issue Oct 19, 2023
AKZhuk added a commit that referenced this issue Oct 19, 2023
 - Migrate to Indigo 1.15.0-dev.4 in-browser
AKZhuk added a commit that referenced this issue Oct 20, 2023
 - Migrate to Indigo 1.15.0-dev.4 in-browser
- Update snapshots
AKZhuk added a commit that referenced this issue Oct 23, 2023
 - Migrate to Indigo 1.15.0-rc.1 in-browser
 - Update snapshots
AKZhuk added a commit that referenced this issue Oct 24, 2023
AKZhuk added a commit that referenced this issue Oct 24, 2023
Nitvex pushed a commit that referenced this issue Oct 24, 2023
…3433)

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Migrate to Indigo 1.15.0-rc.1 in-browser
 - Update snapshots

* - updated snapshot

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Fix pr comments

* #3393 - Add new keyboard shortcut "ctrl+alt+V" for pasting as SMARTS
 - Fix pr comments part 2

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
@AKZhuk AKZhuk closed this as completed Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment