-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3459
Comments
9 tasks
AKZhuk
added a commit
that referenced
this issue
Oct 19, 2023
… one purely SMARTS attribute exists - Update e2e snapshots
AKZhuk
added a commit
that referenced
this issue
Oct 19, 2023
… one purely SMARTS attribute exists - Fix isotope position in custom Query
AKZhuk
added a commit
that referenced
this issue
Oct 19, 2023
… one purely SMARTS attribute exists - Fix failed tests
AKZhuk
added a commit
that referenced
this issue
Oct 19, 2023
… one purely SMARTS attribute exists - Fix issue with smarts preview and template preview - Fix failed test
AKZhuk
added a commit
that referenced
this issue
Oct 20, 2023
… one purely SMARTS attribute exists - Update logic for aromaticity property
AKZhuk
added a commit
that referenced
this issue
Oct 20, 2023
… one purely SMARTS attribute exists - Update logic for aromaticity property - Update snapshots
9 tasks
9 tasks
Nitvex
pushed a commit
that referenced
this issue
Oct 23, 2023
… one purely SMARTS attribute exists (#3465) * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists - Update e2e snapshots * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists - Fix isotope position in custom Query * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists - Fix failed tests * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists - Fix issue with smarts preview and template preview - Fix failed test * #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists - Update logic for aromaticity property - Update snapshots * - updated snapshot --------- Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
AKZhuk
added a commit
that referenced
this issue
Oct 23, 2023
…if at least one purely SMARTS attribute exists
9 tasks
AKZhuk
added a commit
that referenced
this issue
Oct 23, 2023
…if at least one purely SMARTS attribute exists
Nitvex
added a commit
that referenced
this issue
Oct 25, 2023
…if at least one purely SMARTS attribute exists (#3486) * Backmerge: #3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists * - updated snapshot * Merge branch 'master' into 3459-all-atom-attributes-should-be-displayed-as-smarts-if-at-least-one-purely-smarts-attribute-exists-1 --------- Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com> Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Current State
Currently atom attributes are split onto two categories: General and Query Specific.
General properties represent base chemical attributes (charge, isotope mass, valence, radical) and atom alias. Each of these properties, if defined, has its own way of visualization on canvas:
Query Specific properties (ring bond count, H count, substitution count, aromaticity, chirality, etc) represent those properties used in search queries and are displayed as a simple semicolon separated list:
There are two problems with current representation of atom attributes:
s<n>
vsd<n>
for substitution count,rb<n>
vsx<n>
for ring bond count. Other properties have only SMARTS notation, e.g. chirality, aromaticity.Properties from the first set are always displayed in Ketcher notation and when mixed in a common list with properties from the second set, resulting set includes a mix of both notations.
Target State (at least one SMARTS)
If at least one SMARTS specific property is defined, the whole set of atom properties (including general and query specific) should be interpreted as SMARTS properties and displayed based on the following rules:
(IV)
for valence, av4
attribute should be added to the attributes list.The list of SMARTS notations for atom properties is as follows:
#<n>
-<n>
+<n>
<n>
v<n>
x<n>
D<n>
H<n>
h<n>
#<n1>,#<n2>,...
!#<n1>,!#<n2>,...
*
a
A
R<n>
r<n>
X<n>
@@
@
Target State (no SMARTS features)
If no SMARTS features defined, then Ketcher should display the properties the same way as currently (e.g. valence with
I,II,III
, ring bond count withrb<n>
, atom list with[E1,E2,....]
except the following changesThe text was updated successfully, but these errors were encountered: