#3459 - All atom attributes should be displayed as SMARTS if at least one purely SMARTS attribute exists #3465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one purely SMARTS attribute exists
auto-assign
bot
requested review from
chgayane,
SashaGraves and
ViktoriaTkacheva
AKZhuk
changed the title
… one purely SMARTS attribute exists - Update e2e snapshots
This was
linked to
issues
Oct 19, 2023
… one purely SMARTS attribute exists - Fix isotope position in custom Query
… one purely SMARTS attribute exists - Fix failed tests
… one purely SMARTS attribute exists - Fix issue with smarts preview and template preview - Fix failed test
chgayane
approved these changes
Oct 19, 2023
… one purely SMARTS attribute exists - Update logic for aromaticity property - Update snapshots
AKZhuk
force-pushed
the
3459-all-atom-attributes-should-be-displayed-as-smarts-if-at-least-one-purely-smarts-attribute-exists
branch
from
b0abfaa to
047c464
Compare
SashaGraves
approved these changes
Oct 20, 2023
ViktoriaTkacheva
approved these changes
Oct 20, 2023
AKZhuk
changed the base branch from
release/smarts-enhancement
to
release/2.16
Nitvex
deleted the
3459-all-atom-attributes-should-be-displayed-as-smarts-if-at-least-one-purely-smarts-attribute-exists
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
Screen.Recording.2023-10-19.at.10.53.21.mov
Check list
#1234 – issue name