Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query. #3445

Closed
AKZhuk opened this issue Oct 13, 2023 · 1 comment · Fixed by #3446
Closed

Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query. #3445

AKZhuk opened this issue Oct 13, 2023 · 1 comment · Fixed by #3446
Assignees
@AKZhuk
Labels
bug epic: smarts
Milestone
Ketcher 2.16.0-rc.1

Comments

@AKZhuk
Copy link
Collaborator

AKZhuk commented Oct 13, 2023 •
edited
Loading

Steps to Reproduce
Launch "Ketcher"
Draw the Template "Benzene" on the canvas
Click on any atom
Click on the "Edit" button in the context menu
Add Substitution count, Ring bond count, unsaturated Atom Properties from the "Query specific" section
Click on the "Custom Query" checkbox
Verify the value in custom query text area.

Actual behaviour
Substitution count converts to sb{v}, Ring bond count converts to rb{v}, unsaturated converts to u.

Expected behaviour
Substitution count should converts to D{v}. Values "as drawn" and "0" should convert to D0
Ring bond count should converts to x{v}. Values "as drawn" and "0" should convert to x0
Unsaturated property should be absent in custom query text area

Screenshots
image
image
@AKZhuk AKZhuk added this to the Ketcher 2.16.0-rc.1 milestone Oct 13, 2023
@AKZhuk AKZhuk self-assigned this Oct 13, 2023
AKZhuk added a commit that referenced this issue Oct 13, 2023
@AKZhuk
#3445 - Atom properties "Substitution count" and "Ring bond count" co…
09ba2b9 
…nvert incorrectly to custom query
@AKZhuk AKZhuk linked a pull request Oct 13, 2023 that will close this issue
#3445 - Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query #3446
Merged
9 tasks
AKZhuk added a commit that referenced this issue Oct 16, 2023
@AKZhuk
#3445 - Atom properties "Substitution count" and "Ring bond count" co…
64c8788 
…nvert incorrectly to custom query

- Remove property "unsaturated" from custom query
Nitvex pushed a commit that referenced this issue Oct 16, 2023
@AKZhuk
#3445 - Atom properties "Substitution count" and "Ring bond count" co…
5b53d66 
…nvert incorrectly to custom query (#3446)

* #3445 - Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query

* #3445 - Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query
- Remove property "unsaturated" from custom query
@ViktoriaTkacheva
Copy link
Collaborator

Preview. No comments

image

OlgaMazurina pushed a commit that referenced this issue Oct 18, 2023
@AKZhuk
#3445 - Atom properties "Substitution count" and "Ring bond count" co…
8d96cef 
…nvert incorrectly to custom query (#3446)

* #3445 - Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query

* #3445 - Atom properties "Substitution count" and "Ring bond count" convert incorrectly to custom query
- Remove property "unsaturated" from custom query
@AKZhuk AKZhuk modified the milestones: Ketcher 2.16.0-rc.1, SMART-Enhancement Oct 18, 2023
@Nitvex Nitvex modified the milestones: SMART Enhancement, Ketcher 2.16.0-rc.1 Oct 23, 2023
@urszula-gawlowska urszula-gawlowska mentioned this issue Nov 16, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AKZhuk AKZhuk

Labels
bug epic: smarts
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.16.0-rc.1
3 participants
@AKZhuk @Nitvex @ViktoriaTkacheva