-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Displaying side chain connections in snake-like mode #3532
Labels
feature request
Snake mode
Bucket: Snake mode related issues
Test Cases Written
Test cases has been written for that issue
Milestone
Comments
olganaz
changed the title
[Macro] Displaying side chain connections in snake-like mode for peptides
Macro: Displaying side chain connections in snake-like mode for peptides
Apr 19, 2024
olganaz
changed the title
Macro: Displaying side chain connections in snake-like mode for peptides
Macro: Displaying side chain connections in snake-like mode
May 23, 2024
Question to @olganaz
|
|
rrodionov91
changed the title
Macro: Displaying side chain connections in snake-like mode
Displaying side chain connections in snake-like mode
Jun 12, 2024
AlexeyGirin
added
Test Cases Written
Test cases has been written for that issue
and removed
Questions remain
If that issue has unresolved questions
labels
Jun 13, 2024
9 tasks
rrodionov91
added a commit
that referenced
this issue
Jul 2, 2024
- created CanvasMatrix which represents all entities after snake layout as a grid - added drawing of PolymerBond by using CanvasMatrix as a bond way reference #4955 - Update indigo to 1.22.0-rc.1 in browser module - updated ketcher to 2.23.0-rc.1
This was referenced Jul 9, 2024
Closed
Closed
Closed
Closed
R1-R1 connection is established between two monomers occupying first positions displayed wrong
#5069
Open
p.8 is not implemented and will be moved to dedicated task by @rrodionov91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature request
Snake mode
Bucket: Snake mode related issues
Test Cases Written
Test cases has been written for that issue
Background
There are two major types of monomer sequences supported implicitly by Ketcher:
Bonds forming the backbone chain are backbone connections, bonds in side chains -- side chain connections.
Specific case of side chain connection is when the connection is established directly between two backbone monomers (e.g. connecting them via R3/R4), i.e. there are no monomers in the side chain. In scope of this task we consider this type of side chain connection only.
Requirements
Currently side-chain connection in snake (left-to-right) mode is displayed as a straight line connecting two monomers, with no respect to other monomers and bonds. This results in messy visualization and suboptimal user experience.
Instead, side chain connections should be displayed as rounded elbow connectors aligned with existing monomers and other bonds (see wireframes below). The following rules should be applied:
Alternatives
The same logic of connections is applied for CHEMs, unknown monomers and unsplit nucleotides.
UI
r1-r1
r3-r2
r2-r2
r1-r3
r3-r3
RNA
The text was updated successfully, but these errors were encountered: