Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame. Forever. #5074

Closed
AlexeyGirin opened this issue Jul 11, 2024 · 2 comments · Fixed by #5094 or #5101
Closed

Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame. Forever. #5074

AlexeyGirin opened this issue Jul 11, 2024 · 2 comments · Fixed by #5094 or #5101
Assignees
@rrodionov91
Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.23.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jul 11, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules - Flex mode <---Important!
  2. Load from file:
    Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame.zip
    image
  3. Switch view to Sequence mode
  4. Switch back to Snake mode

Actual behavior
Canvas forever shifted to the left and down partially beyond visisbility frame
image

Expected behavior
No shifting
image

Environment details:

  • Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
  • Indigo Toolkit Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #3532
@AlexeyGirin AlexeyGirin added bug Priority: High Sequence mode Bucket: Sequence mode related issues Snake mode Bucket: Snake mode related issues labels Jul 11, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.3 milestone Jul 11, 2024
@AlexeyGirin AlexeyGirin changed the title Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame. Forever. Jul 11, 2024
@Zhirnoff
Copy link
Collaborator

Maybe this will help developers understand the cause of bug: when I pressed zoom 100%, structure was centered.

2024-07-11_17h56_39.mp4

@rrodionov91 rrodionov91 self-assigned this Jul 12, 2024
rrodionov91 added a commit that referenced this issue Jul 12, 2024
@rrodionov91
#5074 - Switching from Sequence mode to Snake mode and back shifts vi…
4c00ab4 
…sible area of canvas beyond visible frame. Forever.

- added applying scroll to top left corner of structure during snake mode initialisation
@rrodionov91 rrodionov91 linked a pull request Jul 12, 2024 that will close this issue
#5074 - Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame. Forever. #5094
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 14, 2024
@rrodionov91
#5074 - Switching from Sequence mode to Snake mode and back shifts vi…
11adc32 
…sible area of canvas beyond visible frame. Forever.

- fixed autoscroll during snake layout
rrodionov91 added a commit that referenced this issue Jul 14, 2024
@rrodionov91
#5074 - Switching from Sequence mode to Snake mode and back shifts vi…
08e1f87 
…sible area of canvas beyond visible frame. Forever. (#5094)

- added applying scroll to top left corner of structure during snake mode initialisation
rrodionov91 added a commit that referenced this issue Jul 14, 2024
@rrodionov91
#5074 - Switching from Sequence mode to Snake mode and back shifts vi…
2ddfc8b 
…sible area of canvas beyond visible frame. Forever.

- added applying scroll to top left corner of structure during snake mode initialisation
rrodionov91 added a commit that referenced this issue Jul 14, 2024
@rrodionov91
#5074 - Switching from Sequence mode to Snake mode and back shifts vi…
6b2cc63 
…sible area of canvas beyond visible frame. Forever.

- fixed autoscroll during snake layout
@rrodionov91 rrodionov91 linked a pull request Jul 14, 2024 that will close this issue
Backmerge: #5074 - Switching from Sequence mode to Snake mode and back shifts visible area of canvas beyond visible frame. Forever. #5101
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
  • Indigo Toolkit Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

svvald pushed a commit that referenced this issue Jul 16, 2024
@rrodionov91 @svvald
Backmerge: #5074 - Switching from Sequence mode to Snake mode and bac…
a017790 
…k shifts visible area of canvas beyond visible frame. Forever.
svvald pushed a commit that referenced this issue Jul 19, 2024
@rrodionov91 @svvald
Backmerge: #5074 - Switching from Sequence mode to Snake mode and bac…
0db4e43 
…k shifts visible area of canvas beyond visible frame. Forever.
rrodionov91 added a commit that referenced this issue Jul 22, 2024
@rrodionov91
Backmerge: #5074 - Switching from Sequence mode to Snake mode and bac…
b383ac3 
…k shifts visible area of canvas beyond visible frame. Forever.
rrodionov91 added a commit that referenced this issue Jul 22, 2024
@rrodionov91
Backmerge: #5074 - Switching from Sequence mode to Snake mode and bac…
5a0fa2b 
…k shifts visible area of canvas beyond visible frame. Forever. (#5101)

- updated screenshots
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High Sequence mode Bucket: Sequence mode related issues Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.23.0-rc.3
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff