Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: While pulling bond onto monomer, a preview is shown when hover monomer #3553

Closed
Zhirnoff opened this issue Nov 8, 2023 · 1 comment · Fixed by #3600
Closed

Macro: While pulling bond onto monomer, a preview is shown when hover monomer #3553

Zhirnoff opened this issue Nov 8, 2023 · 1 comment · Fixed by #3600
Assignees
@ivan-arkhipov-epam
Labels
Macromolecules Priority: Low
Milestone
Macromolecules Mi...

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 8, 2023

Steps to Reproduce

  1. Switch to Macromolecule mode
  2. Add any two monomers on canvas
  3. Select bond tool and start pull bond from one monomer to another
  4. Without releasing left mouse button, stop on the monomer

Actual behavior
While pulling bond onto monomer, a preview is shown when hover monomer

Expected behavior
While pulling bond onto monomer, a preview is not shown when hover monomer

Screenshots

2023-11-08_19h07_20

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.15.0-rc.4
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 3 milestone Nov 8, 2023
@ivan-arkhipov-epam ivan-arkhipov-epam linked a pull request Nov 21, 2023 that will close this issue
#3553 - macro while pulling bond onto monomer a preview is shown when hover monomer #3600
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 27, 2023
@ivan-arkhipov-epam
#3553 - macro while pulling bond onto monomer a preview is shown when…
fd2a633 
… hover monomer (#3600)

* Conditional rendering of the monomer preview
captain2b pushed a commit that referenced this issue Nov 28, 2023
@ivan-arkhipov-epam
#3553 - macro while pulling bond onto monomer a preview is shown when…
ac55991 
… hover monomer (#3600)

* Conditional rendering of the monomer preview
@Zhirnoff
Copy link
Collaborator Author

Tested.

@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ivan-arkhipov-epam ivan-arkhipov-epam

Labels
Macromolecules Priority: Low
Projects
Ketcher
Status: Done
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3553 - macro while pulling bond onto monomer a preview is shown when hover monomer epam/ketcher
4 participants
@rrodionov91 @AlexeyGirin @ivan-arkhipov-epam @Zhirnoff