#3553 - macro while pulling bond onto monomer a preview is shown when hover monomer #3600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitvex
reviewed
Nov 22, 2023
| @@ -208,7 +210,9 @@ function Editor({ theme, togglerComponent }: EditorProps) { | |||
| }); | |||
| editor?.events.mouseOnMoveMonomer.add((e) => { | |||
| handleClosePreview(); | |||
| handleOpenPreview(e); | |||
| if (e.buttons !== 1 || !noPreviewTools.includes(activeTool)) { | |||
There was a problem hiding this comment.
Can we move e.buttons !== 1 to constant like isLeftClick (am I right about this number?). Everything else looks good time from code perspective
ViktoriaTkacheva
approved these changes
Nov 22, 2023
rrodionov91
approved these changes
Nov 27, 2023
rrodionov91
deleted the
3553-macro-while-pulling-bond-onto-monomer-a-preview-is-shown-when-hover-monomer
branch
captain2b
pushed a commit
that referenced
this pull request
Nov 28, 2023
… hover monomer (#3600) * Conditional rendering of the monomer preview
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
This PR prevents monomer preview from being displayed when user is drawing a polymer bond
Check list
#1234 – issue name