-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#3553 - macro while pulling bond onto monomer a preview is shown when hover monomer #3600
Merged
rrodionov91
merged 5 commits into
master
from
3553-macro-while-pulling-bond-onto-monomer-a-preview-is-shown-when-hover-monomer
Nov 27, 2023
Merged
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e21e40e
Conditional rendering of the monomer preview
ivan-arkhipov-epam efdc2ed
more unrelated style fixes
ivan-arkhipov-epam 8154bcf
Changed conditional display of monomer preview
ivan-arkhipov-epam 76b9bd6
Changed conditional display of monomer preview
ivan-arkhipov-epam eb4d790
Put a condition to a meaningful variable
ivan-arkhipov-epam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
import { Page } from "@playwright/test"; | ||
import { Page } from '@playwright/test'; | ||
|
||
// It's a temporary workaround and will be eventually refactored to locator | ||
export async function scrollSettingBar (page: Page, scrollLength: number){ | ||
const deltaX = 0; | ||
const scrollBarCoordinatesX = 638; | ||
const scrollBarCoordinatesY = 524; | ||
await page.mouse.move(scrollBarCoordinatesX, scrollBarCoordinatesY); | ||
await page.mouse.wheel(deltaX, scrollLength); | ||
} | ||
export async function scrollSettingBar(page: Page, scrollLength: number) { | ||
const deltaX = 0; | ||
const scrollBarCoordinatesX = 638; | ||
const scrollBarCoordinatesY = 524; | ||
await page.mouse.move(scrollBarCoordinatesX, scrollBarCoordinatesY); | ||
await page.mouse.wheel(deltaX, scrollLength); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we move
e.buttons !== 1
to constant likeisLeftClick
(am I right about this number?). Everything else looks good time from code perspective