Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Modal window for connecting attachment points does not match the design #3563

Closed
Zhirnoff opened this issue Nov 10, 2023 · 0 comments · Fixed by #3625
Closed

Macro: Modal window for connecting attachment points does not match the design #3563

Zhirnoff opened this issue Nov 10, 2023 · 0 comments · Fixed by #3625
Assignees
@OlgaMazurina
Labels
bug Macromolecules Priority: Medium
Milestone
Macromolecules Mi...

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Nov 10, 2023 •
edited by y-holik
Loading

Steps to Reproduce

  1. Switch to Macromolecule mode
  2. Add Ethylene Glycol and Phosphate monomers on canvas
  3. Select bond tool and start pull bond from one monomer to another
  4. Look at design of modal window for connecting attachment point

Actual behavior
Modal window for connecting attachment points does not match the design
2023-11-10_11h02_50

Expected behavior
Screenshot 2023-11-20 at 2 21 58 PM

differences:
1 - monomers name font
2 - attachment point selectors placement
3 (additional) - when AP are not selected 'Connect' button text should be black - currently white

Modal window for connecting attachment points match the design

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.15.0-rc.4
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 3 milestone Nov 10, 2023
@Nitvex Nitvex mentioned this issue Nov 16, 2023
Closed
@OlgaMazurina OlgaMazurina linked a pull request Nov 28, 2023 that will close this issue
#3563 - Modal window for connecting attachment points does not match the design #3625
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Nov 28, 2023
@OlgaMazurina
#3563 - Modal window for connecting attachment points does not match …
62aa8d4 
…the design (#3625)

* 3563 - fix Modal window style

---------

Co-authored-by: Olga Mazurina <olga_mazurina@epam.com>
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@OlgaMazurina OlgaMazurina

Labels
bug Macromolecules Priority: Medium
Projects
Ketcher
Status: Done
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3563 - Modal window for connecting attachment points does not match the design epam/ketcher
5 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @OlgaMazurina @OlZhur