Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Add possibility to expand "Select Attachment Points" Modal #3580

Closed
Nitvex opened this issue Nov 16, 2023 · 2 comments · Fixed by #3606
Closed

Macro: Add possibility to expand "Select Attachment Points" Modal #3580

Nitvex opened this issue Nov 16, 2023 · 2 comments · Fixed by #3606
Assignees
@AlexeyGirin
Labels
feature request Priority: High
Milestone
Macromolecules Mi...

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Nov 16, 2023 •
edited by olganaz
Loading

Background
When structures with attachment points are large, attachment points become small and hard to distinguish. To provide better UX it is required to add a possibility expand "Select Attachment Points" modal and make attachment points more readable.

Solution
Add a button near "cross icon" in "Select Attachment Points" modal. Click on this button must result in this modal to be expanded.

Acceptance criteria
– Button to expand modal is added
– Click on button makes modal expanded
– Max size of modal is 1280x920
– Molecular structures of monomers in expanded window should have the same scale (the same bond lengths)
– The minimum size of the structure should not be less than in unexpanded "Select Attachment Points" modal.
– Button to collapse expanded view is added. When button is clicked, default modal view is shown

Attachments
MicrosoftTeams-image (43)

Related issues
#3563
#3550
@Nitvex Nitvex added this to the Macromolecules Milestone 3 milestone Nov 16, 2023
@Nitvex Nitvex self-assigned this Nov 16, 2023
@Nitvex Nitvex changed the title Macro: Add possibility expand "Select Attachment Points" Modal Macro: Add possibility to expand "Select Attachment Points" Modal Nov 16, 2023
@Nitvex Nitvex assigned captain2b and unassigned Nitvex Nov 17, 2023
captain2b pushed a commit that referenced this issue Nov 22, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
e23e60b 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
@captain2b captain2b linked a pull request Nov 22, 2023 that will close this issue
#3580 - Macro: Add possibility to expand "Select Attachment Points" Modal #3606
Merged
9 tasks
captain2b pushed a commit that referenced this issue Nov 23, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
06fc58e 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 23, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
55105dd 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 24, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
1931c61 
…odal

dont interfere with other modals styles
captain2b pushed a commit that referenced this issue Nov 24, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
85a19a5 
…odal

dont interfere with other modals styles
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
a1cadd8 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
1aaa83f 
…odal

dont interfere with other modals styles
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
23524c2 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: fix issue with not re-rendering svg
b36493a
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: fix issue with not re-rendering svg
4959b24
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: fix issue with not re-rendering svg
41a39d0
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
e61eba6 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
bd26ecd 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 28, 2023
#3580 - Macro: fix issue with not re-rendering svg
f9ce703
captain2b pushed a commit that referenced this issue Nov 29, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
75d9a13 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 29, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
8ad86a8 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 29, 2023
#3580 - Macro: fix issue with not re-rendering svg
7021c0d
captain2b pushed a commit that referenced this issue Nov 29, 2023
#3580 - Macro: update snapshots
0ff8c97
captain2b pushed a commit that referenced this issue Nov 29, 2023
#3580 - Macro: update snapshots
fb3ba49
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
d7bf402 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
0e46abc 
…odal

add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: fix issue with not re-rendering svg
8f77d3b
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: update snapshots
4c2c3d8
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: update snapshots, style fixes
1b527ab
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: update snapshots, style fixes
c49e848
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: update snapshots, style fixes
86050d9
captain2b pushed a commit that referenced this issue Nov 30, 2023
#3580 - Macro: update snapshots, style fixes
1f95167
rrodionov91 pushed a commit that referenced this issue Nov 30, 2023
@captain2b
#3580 - Macro: Add possibility to expand "Select Attachment Points" M…
cfb891b 
…odal (#3606)

- add new icons, add expand functionality to modal window, change layout of Monomer Connections Modal to match new functionality
- update snapshots, style fixes

---------

Co-authored-by: Mariia_Khrustaleva(EPAM) <Mariia_Khrustaleva@epam.com>
@Zhirnoff
Copy link
Collaborator

Tests added to automation table.

This was referenced Dec 20, 2023
Closed
Open
Open
Open
Closed
@AlexeyGirin AlexeyGirin assigned AlexeyGirin and unassigned captain2b Dec 20, 2023
@AlexeyGirin
Copy link
Collaborator

Verified.

@AlexeyGirin AlexeyGirin mentioned this issue Dec 23, 2023
Open
@olganaz olganaz mentioned this issue Jan 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyGirin AlexeyGirin

Labels
feature request Priority: High
Projects
Macromolecules Milestone 3
Status: Done
Milestone
Macromolecules Milestone 3
Development

Successfully merging a pull request may close this issue.

#3580 - Macro: Add possibility to expand "Select Attachment Points" Modal epam/ketcher
4 participants
@captain2b @AlexeyGirin @Nitvex @Zhirnoff