Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: System marks availiable connection point as unavaliable in Select Connection Point dialog #3736

Closed
AlexeyGirin opened this issue Dec 20, 2023 · 3 comments · Fixed by #3803 or #3926
Closed

Macro: System marks availiable connection point as unavaliable in Select Connection Point dialog #3736

AlexeyGirin opened this issue Dec 20, 2023 · 3 comments · Fixed by #3803 or #3926
Assignees
@chgayane
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.19.0-rc.1

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Dec 20, 2023 •
edited by chgayane
Loading

Issue found in the context of testing #3580

Steps to Reproduce

  1. Switch to Macromolecules view
  2. Load this file: ConnectionDialogTests.zip (unzip first)
  3. Connect R3 connection point of H peptide with center of M peptide
    image
    Select connection dialog appears - this is ok.
  4. Click on R2 connection point for Histidine

Actual behavior
Note that system removes selection from R3 connection point on preview, but paint it as unavailable for connection (already connected)
image
Same problem in expanded mode

Expected behavior
System removes selection from R3 connection point on preview and paint it as available for connection

Desktop (please complete the following information):

  • OS: win10
  • Browser Chrome 120.0.6099.110 (Официальная сборка), (64 бит)

Ketcher version [e.g. v2.4.2].
image
@rrodionov91 rrodionov91 assigned rrodionov91 and unassigned rrodionov91 and Nitvex Dec 26, 2023
@rrodionov91 rrodionov91 linked a pull request Dec 27, 2023 that will close this issue
#3787 - Macro: System allow to connect block to already occupied connection (that cases invalide saved files) #3803
Merged
9 tasks
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Jan 6, 2024 •
edited
Loading

No fixed.
image

Ketcher
Version 2.17.0-rc.2
Build at 2024-01-03; 14:08:44
Feedback
EPAM Life Sciences

Indigo Toolkit
Version 1.17.0-rc.3.0-g1a7f60990-wasm32-wasm-clang-12.0.0

@AlexeyGirin AlexeyGirin reopened this Jan 6, 2024
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Jan 8, 2024

Test added to the automation table.

chgayane added a commit that referenced this issue Jan 18, 2024
@chgayane
#3736 - Refactor and fix bonds update logic in MonomerConnection comp…
b90222a 
…onent
@chgayane chgayane linked a pull request Jan 18, 2024 that will close this issue
Macro: #3736 - System marks availiable connection point as unavaliable in Select Connection Point dialog #3926
Merged
9 tasks
chgayane added a commit that referenced this issue Jan 24, 2024
@chgayane
#3736 - Update removeBond logic to handle selectedAttachmentPoint
4e0c0c9
rrodionov91 pushed a commit that referenced this issue Jan 25, 2024
@chgayane
Macro: #3736 - System marks availiable connection point as unavaliabl…
6765fa5 
…e in Select Connection Point dialog (#3926)
@Zhirnoff
Copy link
Collaborator

Tested. Fixed.
2024-02-21_11h55_56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.19.0-rc.1
5 participants
@rrodionov91 @AlexeyGirin @Nitvex @Zhirnoff @chgayane