Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: The last letter in RNA Builder name field cannot be deleted #3900

Closed
Zhirnoff opened this issue Jan 15, 2024 · 2 comments · Fixed by #3908 or #3995
Closed

Macro: The last letter in RNA Builder name field cannot be deleted #3900

Zhirnoff opened this issue Jan 15, 2024 · 2 comments · Fixed by #3908 or #3995
Assignees
@chgayane
Labels
bug Macromolecules Priority: Low
Milestone
Ketcher 2.18.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Switch to Macro mode
  2. Select RNA tab
  3. Expand RNA Builder
  4. Add any text to name field
  5. Try delete text

Actual behavior
The last letter in RNA Builder name field cannot be deleted.

Expected behavior
The all letters in RNA Builder name field can be deleted.

Screenshots
2024-01-15_22h48_43

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.1]
@Zhirnoff Zhirnoff added this to the Macromolecules Milestone 5 milestone Jan 15, 2024
@rrodionov91 rrodionov91 assigned chgayane and unassigned rrodionov91 Jan 16, 2024
chgayane added a commit that referenced this issue Jan 16, 2024
@chgayane
#3900 - Updated name change handler to allow for complete deletion of…
a4458ce 
… text
@chgayane chgayane linked a pull request Jan 16, 2024 that will close this issue
Backmerge: Macro: #3900 - The last letter in RNA Builder name field cannot be deleted #3908
Merged
9 tasks
chgayane added a commit that referenced this issue Jan 18, 2024
@chgayane
#3900 - Refactored onChangeName to always trim input
7226a73
rrodionov91 pushed a commit that referenced this issue Jan 18, 2024
@chgayane
Macro: #3900 - The last letter in RNA Builder name field cannot be de…
8e28981 
…leted (#3908)

- updated name change handler to allow for complete deletion of text
- refactored onChangeName to always trim input
@Zhirnoff
Copy link
Collaborator Author

Test added to the automation table.

rrodionov91 pushed a commit that referenced this issue Jan 30, 2024
@chgayane @rrodionov91
#3900 - Updated name change handler to allow for complete deletion of…
2fb24c2 
… text
rrodionov91 pushed a commit that referenced this issue Jan 30, 2024
@chgayane @rrodionov91
#3900 - Refactored onChangeName to always trim input
0518e71
@rrodionov91 rrodionov91 linked a pull request Jan 30, 2024 that will close this issue
Macro: #3900 - The last letter in RNA Builder name field cannot be deleted #3995
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 30, 2024
@rrodionov91 @chgayane
Macro: #3900 - The last letter in RNA Builder name field cannot be de…
7aa415b 
…leted (#3995)

- updated name change handler to allow for complete deletion of text

---------

Co-authored-by: chgayane <chgayane08@student.rau.am>
@Zhirnoff
Copy link
Collaborator Author

Zhirnoff commented Feb 1, 2024

Tested. Bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
bug Macromolecules Priority: Low
Projects
None yet
Milestone
Ketcher 2.18.0-rc.3
4 participants
@rrodionov91 @AlexeyGirin @Zhirnoff @chgayane