Backmerge: Macro: #3900 - The last letter in RNA Builder name field cannot be deleted #3908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zhirnoff
approved these changes
Jan 16, 2024
...s/src/components/monomerLibrary/RnaBuilder/RnaEditor/RnaEditorExpanded/RnaEditorExpanded.tsx
Outdated
Show resolved
Hide resolved
StarlaStarla
approved these changes
Jan 18, 2024
rrodionov91
approved these changes
Jan 18, 2024
rrodionov91
deleted the
3900-macro-the-last-letter-in-rna-builder-name-field-cannot-be-deleted
branch
rrodionov91
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
The trim() method in the
onChangeNamefunction prevented the deletion of the last letter. Adjusted logic to allow for the removal of all characters, while still trimming input for the new state.Ketcher.v2.18.0.Vite.-.Google.Chrome.2024-01-17.10-39-14.mp4
Check list
#1234 – issue name