Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule #3949

Closed
Zhirnoff opened this issue Jan 24, 2024 · 1 comment · Fixed by #3975 or #3987
Closed

Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule #3949

Zhirnoff opened this issue Jan 24, 2024 · 1 comment · Fixed by #3975 or #3987
Assignees
@rrodionov91
Labels
bug Priority: High query features phase II
Milestone
Ketcher 2.18.0-rc.3

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add any structure and any molecule on canvas
  3. Choose S-Group tool and select structure with molecule
  4. Select any S-Group type (bug reproduced with all S-Group type)
  5. Save as .ket file and find in it parameter "sgroups": [

Actual behavior
Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule. The S-Group is not saved after opening the file.

Expected behavior
Parameter "sgroups" present in .ket file if a S-Group is applied to structure along with molecule. The S-Group saved after opening the file.

Screenshots

2024-01-24_14h28_13.mp4

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
[Version 2.18.0-rc.2]
@Zhirnoff Zhirnoff added this to the Ketcher 2.19.0-rc.1 milestone Jan 24, 2024
rrodionov91 added a commit that referenced this issue Jan 26, 2024
@rrodionov91
#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group…
8d8df8f 
… is applied to structure along with molecule

- fixed serialization/deserialization in case when one sgroup contains several fragments
@rrodionov91 rrodionov91 linked a pull request Jan 29, 2024 that will close this issue
#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule #3975
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 29, 2024
@rrodionov91
#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group…
0422822 
… is applied to structure along with molecule (#3975)

- fixed serialization/deserialization in case when one sgroup contains several fragments

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Jan 29, 2024
@rrodionov91
#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group…
11182d6 
… is applied to structure along with molecule

- fixed serialization/deserialization in case when one sgroup contains several fragments
@rrodionov91 rrodionov91 linked a pull request Jan 29, 2024 that will close this issue
Backmerge: #3949 - Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule #3987
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 30, 2024
@rrodionov91
Backmerge: #3949 - Parameter "sgroups" does not appear in .ket file i…
aeb8c22 
…f a S-Group is applied to structure along with molecule (#3987)

- fixed serialization/deserialization in case when one sgroup contains several fragments

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
captain2b pushed a commit that referenced this issue Jan 30, 2024
@rrodionov91 @captain2b
#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group…
f80292d 
… is applied to structure along with molecule (#3975)

- fixed serialization/deserialization in case when one sgroup contains several fragments

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

Tested. Bug is fixed.

@rrodionov91 rrodionov91 mentioned this issue Feb 6, 2024
Closed
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High query features phase II
Projects
Ketcher
Status: Done
Milestone
Ketcher 2.18.0-rc.3
3 participants
@rrodionov91 @AlexeyGirin @Zhirnoff