#3949 - Parameter "sgroups" does not appear in .ket file if a S-Group is applied to structure along with molecule #3975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is applied to structure along with molecule - fixed serialization/deserialization in case when one sgroup contains several fragments
auto-assign
bot
requested review from
chgayane,
ilya-asiyuk-epam and
Zhirnoff
- refactored getFragmentsGroupedBySgroup method
ilya-asiyuk-epam
approved these changes
Jan 29, 2024
captain2b
pushed a commit
that referenced
this pull request
Jan 30, 2024
… is applied to structure along with molecule (#3975) - fixed serialization/deserialization in case when one sgroup contains several fragments --------- Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Check list
#1234 – issue name