Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Canvas preview render work at 14 times faster in Firefox than in Chrome #4082

Closed
AlexeyGirin opened this issue Feb 13, 2024 · 3 comments · Fixed by #4117, #4121 or #4120
Closed

Canvas preview render work at 14 times faster in Firefox than in Chrome #4082

AlexeyGirin opened this issue Feb 13, 2024 · 3 comments · Fixed by #4117, #4121 or #4120
Assignees
@rrodionov91
Labels
bug CDX-ChemDraw Bucket: Save/View/Open of CDX forrmat related issues Priority: Medium
Milestone
Ketcher 2.18.0-rc.8

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Feb 13, 2024 •
edited
Loading

Steps to Reproduce
Try both - Chrome and Firefox

  1. Click Open... button (Ctrl+O)
  2. Select open from file
  3. Select file: 50 mols on 1 canvas.pptx
  4. Click Open
    image

Actual behavior
Note that it took ~58 seconds to render preview canvas and only 4 seconds in Firefox

Expected behavior
Chrome render the same speed as FF

Environment details:
@AlexeyGirin AlexeyGirin changed the title Canvas preview render work at 14 tymes faster in Firefox than in Chrome Canvas preview render work at 14 times faster in Firefox than in Chrome Feb 14, 2024
@captain2b
Copy link
Collaborator

captain2b commented Feb 15, 2024 •
edited
Loading

Screenshot 2024-02-15 at 14 09 29

@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Feb 19, 2024 •
edited
Loading

More investigation needed. Seems it is on the Ketcher side.
Probably we have to consider migration to D3 render engine (Macromolecules works on new engine but micro on old one)

rrodionov91 added a commit that referenced this issue Feb 20, 2024
@rrodionov91
#4082 - Canvas preview render work at 14 times faster in Firefox than…
6e38e71 
… in Chrome

- fixed preview wrapper size to make svg elements reflow faster
@rrodionov91 rrodionov91 linked a pull request Feb 20, 2024 that will close this issue
#4082 - Canvas preview render work at 14 times faster in Firefox than in Chrome #4117
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Feb 21, 2024
@rrodionov91
#4082 - Canvas preview render work at 14 times faster in Firefox than…
af5ec89 
… in Chrome (#4117)

- fixed preview wrapper size to make svg elements reflow faster
- fixed styles for empty pptx
- fixed screenshots

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 21, 2024
@rrodionov91
#4082 - Canvas preview render work at 14 times faster in Firefox than…
76d1b04 
… in Chrome

- fixed preview wrapper size to make svg elements reflow faster
rrodionov91 added a commit that referenced this issue Feb 21, 2024
@rrodionov91
#4082 - Canvas preview render work at 14 times faster in Firefox than…
fb76ee7 
… in Chrome

- fixed preview wrapper size to make svg elements reflow faster
This was linked to pull requests Feb 21, 2024
Backmerge: #4082 - Canvas preview render work at 14 times faster in Firefox than in Chrome #4121
Merged
Backmerge: #4082 - Canvas preview render work at 14 times faster in Firefox than in Chrome #4120
Merged
This was referenced Feb 21, 2024
Closed
Closed
@AlexeyGirin
Copy link
Collaborator Author

Verified.
Ketcher Version 2.18.0-rc.7 Build at 2024-02-21; 12:47:03
Indigo Toolkit Version 1.18.0-rc.7.0-g8a5c36802-wasm32-wasm-clang-12.0.0

rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
Backmerge: #4082 - Canvas preview render work at 14 times faster in F…
6966379 
…irefox than in Chrome (#4121)

- fixed preview wrapper size to make svg elements reflow faster
- fixed styles for empty pptx
- fixed screenshots

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
rrodionov91 added a commit that referenced this issue Feb 22, 2024
@rrodionov91
Backmerge: #4082 - Canvas preview render work at 14 times faster in F…
37a6881 
…irefox than in Chrome (#4120)

- fixed preview wrapper size to make svg elements reflow faster
- fixed styles for empty pptx
- fixed screenshots

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@AlexeyGirin AlexeyGirin added CDX-ChemDraw Bucket: Save/View/Open of CDX forrmat related issues and removed ChemDraw labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug CDX-ChemDraw Bucket: Save/View/Open of CDX forrmat related issues Priority: Medium
Projects
None yet
Milestone
Ketcher 2.18.0-rc.8
3 participants
@captain2b @rrodionov91 @AlexeyGirin