Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it #4297

Closed
ViktoriaTkacheva opened this issue Mar 21, 2024 · 1 comment · Fixed by #4302 or #4312
Closed

Macro: When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it #4297

ViktoriaTkacheva opened this issue Mar 21, 2024 · 1 comment · Fixed by #4302 or #4312
Labels
bug Macromolecules Priority: Medium
Milestone
Ketcher 2.20.0-rc.2

Comments

@ViktoriaTkacheva
Copy link
Collaborator

Steps to Reproduce

  1. Launch “Ketcher” and switch to the Macro mode
  2. Switch to the Sequence mode
  3. Right-click on the canvas and select the “Start new sequence” option
  4. Enter any nucleotides (for example, AAAAA)
  5. Hover over any nucleotide in this chain and delete the entire nucleotide chain
  6. Click on the “Clear canvas” button

Actual behavior
When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it. Using the “Undo” and “Clear canvas” buttons the preview is also not removed

Expected behavior
When removing nucleotides from the canvas, the preview of the nucleotide disappears, if you leave the cursor over it

Screenshots

2024-03-20_10h51_17.mp4
2024-03-20_11h02_05.mp4

Desktop (please complete the following information):

  • OS: Windows 10 Pro (version 22H2) x64
  • Browser: Сhrome
  • Version: (122.0.6261.112) x64

Ketcher version 2.20.0-rc.1
@ViktoriaTkacheva ViktoriaTkacheva added this to the Ketcher 2.20.0-rc.2 milestone Mar 21, 2024
rrodionov91 added a commit that referenced this issue Mar 21, 2024
@rrodionov91
#4297 - Macro: When removing nucleotides from the canvas, the preview…
636d578 
… of the nucleotide does not disappear, if you leave the cursor over it

- added removing preview on mousemove and keypress
- added getting canvas and canvasWrapper from ZoomTool to find it in DOM once instead of on each renderer creation
- added async rendering after each keypress event handled in sequence edit mode
@rrodionov91 rrodionov91 linked a pull request Mar 21, 2024 that will close this issue
#4297 - Macro: When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it #4302
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Mar 21, 2024
@rrodionov91
#4297 - Macro: When removing nucleotides from the canvas, the preview…
7a6d560 
… of the nucleotide does not disappear, if you leave the cursor over it (#4302)

- added removing preview on mousemove and keypress
- added getting canvas and canvasWrapper from ZoomTool to find it in DOM once instead of on each renderer creation
- added async rendering after each keypress event handled in sequence edit mode
rrodionov91 added a commit that referenced this issue Mar 21, 2024
@rrodionov91
#4297 - Macro: When removing nucleotides from the canvas, the preview…
e2921f7 
… of the nucleotide does not disappear, if you leave the cursor over it

- added removing preview on mousemove and keypress
- added getting canvas and canvasWrapper from ZoomTool to find it in DOM once instead of on each renderer creation
- added async rendering after each keypress event handled in sequence edit mode
@rrodionov91 rrodionov91 linked a pull request Mar 21, 2024 that will close this issue
Backmerge: #4297 - Macro: When removing nucleotides from the canvas, the preview of the nucleotide does not disappear, if you leave the cursor over it #4312
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Mar 22, 2024
@rrodionov91
Backmerge: #4297 - Macro: When removing nucleotides from the canvas, …
493e920 
…the preview of the nucleotide does not disappear, if you leave the cursor over it (#4312)

- added removing preview on mousemove and keypress
- added getting canvas and canvasWrapper from ZoomTool to find it in DOM once instead of on each renderer creation
- added async rendering after each keypress event handled in sequence edit mode

---------

Co-authored-by: Roman Rodionov <roman_rodionov@epam.com>
@Zhirnoff
Copy link
Collaborator

Tested on build 2.20.0-rc.2 Bug is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Macromolecules Priority: Medium
Projects
None yet
Milestone
Ketcher 2.20.0-rc.2
2 participants
@Zhirnoff @ViktoriaTkacheva