Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any click on toobar buttons should cause cancel of "Modify in RNA builder" process #4470

Closed
AlexeyGirin opened this issue Apr 16, 2024 · 3 comments · Fixed by #4625
Closed
Assignees
Labels
bug Priority: Medium RNA Builder Bucket: RNA builder related issues

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Apr 16, 2024

Steps to Reproduce

  1. Switch to Macro
  2. Open from file: Sample sequence.zip
  3. Select few nucleotides and edit them in RNA builder (via context menu)
    image
  4. Press Clear canvas button

Actual behavior
Canvas got empty but RNA builder remain in edit mode
image

Expected behavior

  1. System closes "Modify in RNA builder" mode and than process with Clear canvas button

image

  1. System disables "Open..." button, "Type" selector in Top bar while sequence is in 'Edit in RNA Builder' mode

  2. Systems does not allow new element via API (ketcher.addFragment, ketcher.setMolecule) while sequence is in 'Edit in RNA Builder' mode

Versions:
Windows 10
Chrome Version Version 123.0.6312.106 (Official Build) (64-bit)
Ketcher Version 2.21.0-rc.1 Build at 2024-04-15; 20:00:15
Indigo Toolkit Version 1.20.0-rc.1.0-g8e8ffc3c3-wasm32-wasm-clang-12.0.0

Issue found while testing #4374

@Zhirnoff
Copy link
Collaborator

The issue has been moved from 2.21.0-rc.2 to 2.22.0-rc.1 after discussion with management and in accordance with the testing flow process.

@AlexeyGirin AlexeyGirin added the RNA Builder Bucket: RNA builder related issues label Apr 25, 2024
@ilya-asiyuk-epam ilya-asiyuk-epam self-assigned this May 15, 2024
ilya-asiyuk-epam added a commit that referenced this issue May 15, 2024
@ilya-asiyuk-epam
Copy link
Contributor

ilya-asiyuk-epam commented May 15, 2024

I think there are 3 elements that we need to handle in this bug.

modify in rna builder

And disable adding new elements on the canvas via API (ketcher.addFragment, ketcher.setMolecule)

cc: @AlexeyGirin , @rrodionov91

ilya-asiyuk-epam added a commit that referenced this issue May 16, 2024
ilya-asiyuk-epam added a commit that referenced this issue May 16, 2024
ilya-asiyuk-epam added a commit that referenced this issue May 16, 2024
…hould-cause-cancel-of-modify-in-rna-builder-process

#4470 - Any click on toobar buttons should cause cancel of "Modify in RNA builder" process
@AlexeyGirin
Copy link
Collaborator Author

Verified.

  • Indigo Toolkit Version 1.21.0-dev.3.0-g6f55c664-wasm32-wasm-clang-12.0.0
  • Ketcher Version 2.21.0-rc.2 Build at 2024-05-20; 05:30:45
  • Chrome Version 124.0.6367.201 (Official Build) (64-bit)
  • Windows 10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Priority: Medium RNA Builder Bucket: RNA builder related issues
Projects
None yet
3 participants