Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4740

Closed
AlexeyGirin opened this issue Jun 4, 2024 · 1 comment · Fixed by #4761 or #4762
Closed

Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4740

AlexeyGirin opened this issue Jun 4, 2024 · 1 comment · Fixed by #4761 or #4762
Assignees
@rrodionov91
Labels
bug Priority: Medium Sequence mode Bucket: Sequence mode related issues
Milestone
Ketcher 2.22.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

This is follow up of #4708

Steps to Reproduce

  1. Load from file: two cycles.zip
    OR put on the canvas following configuration:
    image
  2. Switch to Sequence mode
  3. Select bottom sequence and press Delete key
    image

Actual behavior
System deletes bottom sequence (this is ok) but also deletes bond that cycles top sequence (this is not ok)
image

Expected behavior
System deletes bottom sequence only
image

Versions:

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-03; 18:43:00
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10
@AlexeyGirin AlexeyGirin added the bug label Jun 4, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.22.0-rc.3 milestone Jun 4, 2024
@AlexeyGirin AlexeyGirin added Sequence mode Bucket: Sequence mode related issues Priority: Medium labels Jun 4, 2024
@rrodionov91 rrodionov91 self-assigned this Jun 5, 2024
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
4ca6e34 
…other cycled sequence bond that makes it non-cycled

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
bd58691 
…other cycled sequence bond that makes it non-cycled

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
@rrodionov91 rrodionov91 linked a pull request Jun 5, 2024 that will close this issue
#4740 - Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4761
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 5, 2024
@rrodionov91
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
8cea293 
…other cycled sequence bond that makes it non-cycled

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
@rrodionov91 rrodionov91 linked a pull request Jun 5, 2024 that will close this issue
Backmerge: #4740 - Delete of cycled sequnece from the canvas causes delete of another cycled sequence bond that makes it non-cycled #4762
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
9ffa2d2 
…other cycled sequence bond that makes it non-cycled

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
#4740 - Delete of cycled sequnece from the canvas causes delete of an…
a6f5ce4 
…other cycled sequence bond that makes it non-cycled (#4761)

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
rrodionov91 added a commit that referenced this issue Jun 6, 2024
@rrodionov91
Backmerge: #4740 - Delete of cycled sequnece from the canvas causes d…
b0ea8c2 
…elete of another cycled sequence bond that makes it non-cycled (#4762)

- skip handling of adding/deleteing phosphates and establishing bonds if selection if on the bound of chain
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image

  • Indigo Toolkit Version 1.21.0-rc.1.0-g9194599b2-wasm32-wasm-clang-19.0.0
  • Ketcher Version 2.22.0-rc.3 Build at 2024-06-10; 12:34:49
  • Chrome Version 125.0.6422.142 (Official Build) (64-bit)
  • Windows 10

@ViktoriaTkacheva ViktoriaTkacheva mentioned this issue Jul 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: Medium Sequence mode Bucket: Sequence mode related issues
Projects
None yet
Milestone
Ketcher 2.22.0-rc.3
2 participants
@rrodionov91 @AlexeyGirin