Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RNA Preset without Base causes constant crash after switching to Macromolecules mode #4924

Closed
AlexeyGirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #5016 or #5022
Closed

RNA Preset without Base causes constant crash after switching to Macromolecules mode #4924

AlexeyGirin opened this issue Jun 28, 2024 · 1 comment · Fixed by #5016 or #5022
Assignees
@rrodionov91
Labels
bug Priority: High RNA Builder Bucket: RNA builder related issues
Milestone
Ketcher 2.23.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Jun 28, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Go to RNA tab at Library
  3. Press New Preset button and create preset without Base
    image
  4. Press Add to Presets button
  5. Reload Ketcher
  6. Switch to Macromolecules mode

Actual behavior
System crashes into white screen forever and even reload of the page (including with Ctrl+F5) doesn't help
image
ci.test.lifescience.opensource.epam.com-1719582442844.log
ci.test.lifescience.opensource.epam.com-1719582447509.log

Expected behavior
No crash happens

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #4382
@AlexeyGirin AlexeyGirin added bug Priority: High RNA Builder Bucket: RNA builder related issues labels Jun 28, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 28, 2024
@Guch1g0v Guch1g0v self-assigned this Jul 3, 2024
Guch1g0v added a commit that referenced this issue Jul 4, 2024
@Guch1g0v
#4924 - RNA Preset without Base causes constant crash after switching…
5ec239b 
… to Macromolecules mode
@Guch1g0v Guch1g0v linked a pull request Jul 4, 2024 that will close this issue
#4924 - RNA Preset without Base causes constant crash after switching to Macromolecules mode #4988
Closed
9 tasks
rrodionov91 added a commit that referenced this issue Jul 4, 2024
@rrodionov91
#4924 - RNA Preset without Base causes constant crash after switching…
d1c5549 
… to Macromolecules mode

- added safety checks in rna presets getter
@rrodionov91 rrodionov91 linked a pull request Jul 5, 2024 that will close this issue
Backmerge: #4924 - RNA Preset without Base causes constant crash after switching to Macromolecules mode #5016
Merged
9 tasks
@Guch1g0v Guch1g0v assigned rrodionov91 and unassigned Guch1g0v Jul 5, 2024
rrodionov91 added a commit that referenced this issue Jul 6, 2024
@rrodionov91
#4924 - RNA Preset without Base causes constant crash after switching…
ce1fec1 
… to Macromolecules mode

- added safety checks in rna presets getter
@rrodionov91 rrodionov91 linked a pull request Jul 6, 2024 that will close this issue
#4924 - RNA Preset without Base causes constant crash after switching to Macromolecules mode #5022
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 6, 2024
@rrodionov91
#4924 - RNA Preset without Base causes constant crash after switching…
3082112 
… to Macromolecules mode (#5016)

- added safety checks in rna presets getter
rrodionov91 added a commit that referenced this issue Jul 6, 2024
@rrodionov91
#4924 - RNA Preset without Base causes constant crash after switching…
9d23ee8 
… to Macromolecules mode (#5022)

- added safety checks in rna presets getter
@AnnaKosol
Copy link
Contributor

Tested, ok
https://github.com/epam/ketcher/assets/174325443/28522a83-6073-4681-ad68-1b0a2a3a3f49
Versions:
Ketcher Version 2.23.0-rc.2 Build at 2024-07-10; 19:39:22
Indigo Version 1.22.0-rc.2.0-ga21fb5d8f-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug Priority: High RNA Builder Bucket: RNA builder related issues
Projects
None yet
Milestone
Ketcher 2.23.0-rc.2
4 participants
@rrodionov91 @AlexeyGirin @Guch1g0v @AnnaKosol