Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Enumeration is missing for cycled unsplit nucleotides after load from file (KET/MOL doesn't matter) #4935

Closed
AlexeyGirin opened this issue Jun 29, 2024 · 2 comments · Fixed by #5251 or #5272
Closed

Preview: Enumeration is missing for cycled unsplit nucleotides after load from file (KET/MOL doesn't matter) #4935

AlexeyGirin opened this issue Jun 29, 2024 · 2 comments · Fixed by #5251 or #5272
Assignees
@rrodionov91
Labels
Flex mode Bucket: Flex canvas related mode Priority: High
Milestone
Ketcher 2.24.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

Steps to Reproduce

  1. Go to Macromolecules mode - Flex mode
  2. Load from file: Cycled nucleotides.zip
    OR manually create the following configuration, save it to ket and load as new project:
    image

Actual behavior
Enumeration is missing
image

Expected behavior
Enumeration is in place
image

Versions

  • Ketcher Version 2.22.0-rc.2 Build at 2024-06-28; 05:30:15
  • Indigo Toolkit Version 1.22.0-dev.2.1-gd5637f75-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 126.0.6478.127 (Official Build) (64-bit)

Issue found while testing - #4382
@AlexeyGirin AlexeyGirin added bug Priority: High Flex mode Bucket: Flex canvas related mode labels Jun 29, 2024
@AlexeyGirin AlexeyGirin added this to the Ketcher 2.23.0-rc.1 milestone Jun 29, 2024
@AlexeyGirin
Copy link
Collaborator Author

Enumeration should start from top left monomer

@rrodionov91 rrodionov91 self-assigned this Aug 8, 2024
rrodionov91 added a commit that referenced this issue Aug 8, 2024
@rrodionov91
#4935 - Preview: Enumeration is missing for cycled unsplit nucleotide…
5c294c7 
…s after load from file (KET/MOL doesn't matter)
@rrodionov91 rrodionov91 linked a pull request Aug 8, 2024 that will close this issue
Backmerge: #4935 - Preview: Enumeration is missing for cycled unsplit nucleotides after load from file (KET/MOL doesn't matter) #5251
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#4935 - Preview: Enumeration is missing for cycled unsplit nucleotide…
64a3b3c 
…s after load from file (KET/MOL doesn't matter)
@rrodionov91 rrodionov91 linked a pull request Aug 9, 2024 that will close this issue
#4935 - Preview: Enumeration is missing for cycled unsplit nucleotides after load from file (KET/MOL doesn't matter) #5272
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
Backmerge: #4935 - Preview: Enumeration is missing for cycled unsplit…
e72cc05 
… nucleotides after load from file (KET/MOL doesn't matter) (#5251)

- added check for cyclic chain beginning
rrodionov91 added a commit that referenced this issue Aug 9, 2024
@rrodionov91
#4935 - Preview: Enumeration is missing for cycled unsplit nucleotide…
c27e667 
…s after load from file (KET/MOL doesn't matter) (#5272)

* - added check for chain beginning
@AlexeyGirin
Copy link
Collaborator Author

Fixed.
image

  • Ketcher Version 2.24.0-rc.2 Build at 2024-08-14; 19:00:14
  • Indigo Toolkit Version 1.23.0-rc.2.0-g6a2a7526a-wasm32-wasm-clang-19.0.0
  • Chrome Version 127.0.6533.100 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #4935 - Preview: Enumeration is missing for cycled unsplit…
474bd23 
… nucleotides after load from file (KET/MOL doesn't matter) (#5251)

- added check for cyclic chain beginning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Flex mode Bucket: Flex canvas related mode Priority: High
Projects
None yet
Milestone
Ketcher 2.24.0-rc.2
3 participants
@rrodionov91 @AlexeyGirin @KristinaKasyanovskaya