Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connection between molecule and monomer lost after opening and saving to ket #4973

Closed
rrodionov91 opened this issue Jul 3, 2024 · 1 comment · Fixed by #4971, #4980 or #4970
Closed

Connection between molecule and monomer lost after opening and saving to ket #4973

rrodionov91 opened this issue Jul 3, 2024 · 1 comment · Fixed by #4971, #4980 or #4970
Assignees
@rrodionov91
Labels
bug
Milestone
Ketcher 2.22.0-rc.9

Comments

@rrodionov91
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher.
  2. Draw a benzene ring
  3. Add an attachment point to the benzene ring via right click menu
  4. Switch to Macro mode and connect attachment point to a macro structure
  5. Switch to Micro mode
  6. Save structure in KET format
  7. Open saved file in micro mode using Add to canvas button
  8. Move mouse with paste preview over the canvas
  9. Click on canvas
  10. Save structure in KET format

Actual behavior
Connection between molecule and monomer is NOT saved in ket file

Expected behavior
Connection between molecule and monomer is saved in ket file

Ketcher version [e.g. v2.4.2].
v2.22.0-rc.8
@rrodionov91 rrodionov91 added the bug label Jul 3, 2024
@rrodionov91 rrodionov91 added this to the Ketcher 2.22.0-rc.9 milestone Jul 3, 2024
@rrodionov91 rrodionov91 self-assigned this Jul 3, 2024
@rrodionov91 rrodionov91 changed the title Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong Connection between molecule and monomer lost after opening and saving to ket Jul 3, 2024
rrodionov91 added a commit that referenced this issue Jul 3, 2024
@rrodionov91
#4973 - Connection between molecule and monomer lost after opening an…
b77e708 
…d saving to ket

- fixed monomer atoms ids mapping during struct clone
@rrodionov91 rrodionov91 linked a pull request Jul 3, 2024 that will close this issue
Backmerge: #4879 - Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong #4971
Merged
9 tasks
@rrodionov91 rrodionov91 mentioned this issue Jul 3, 2024
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 3, 2024
@rrodionov91
#4973 - Connection between molecule and monomer lost after opening an…
ce018cb 
…d saving to ket

- fixed monomer atoms ids mapping during struct clone
@rrodionov91 rrodionov91 linked a pull request Jul 3, 2024 that will close this issue
#4973 - Connection between molecule and monomer lost after opening and saving to ket #4980
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 3, 2024
@rrodionov91
#4973 - Connection between molecule and monomer lost after opening an…
25ab082 
…d saving to ket

- fixed monomer atoms ids mapping during struct clone
@rrodionov91 rrodionov91 mentioned this issue Jul 3, 2024
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Jul 3, 2024 that will close this issue
Backmerge: #4879 - Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong #4970
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jul 4, 2024
@rrodionov91
#4973 - Connection between molecule and monomer lost after opening an…
46d3f1f 
…d saving to ket (#4980)

- fixed monomer atoms ids mapping during struct clone
- fixed removeLeavingGroupsFromConnectedAtoms
rrodionov91 added a commit that referenced this issue Jul 4, 2024
@rrodionov91
Backmerge: #4879 - Ketcher part: Save to mol for micro and macro stru…
c1c36a4 
…ctures connected through attachment points works wrong (#4970)

- added removing the leavingGroup atom from structure before serialisation if there is connection to monomer

* #4973 - Connection between molecule and monomer lost after opening and saving to ket

- fixed monomer atoms ids mapping during struct clone
- fixed removeLeavingGroupsFromConnectedAtoms
rrodionov91 added a commit that referenced this issue Jul 4, 2024
@rrodionov91
Backmerge: #4879 - Ketcher part: Save to mol for micro and macro stru…
d994377 
…ctures connected through attachment points works wrong (#4971)

- added removing the leavingGroup atom from structure before serialisation if there is connection to monomer

* #4973 - Connection between molecule and monomer lost after opening and saving to ket

- fixed monomer atoms ids mapping during struct clone
- fixed removeLeavingGroupsFromConnectedAtoms
@AlexeyGirin
Copy link
Collaborator

Verified.
image

Ketcher Version 2.22.0-rc.9 Build at 2024-07-04; 15:58:14
Indigo Version 1.21.0-rc.3.0-g1570d3f9f-wasm32-wasm-clang-19.0.0
Win 10
Chrome Version 126.0.6478.127 (Official Build) (64-bit)

accmeboot pushed a commit that referenced this issue Jul 5, 2024
@rrodionov91
Backmerge: #4879 - Ketcher part: Save to mol for micro and macro stru…
ba63adc 
…ctures connected through attachment points works wrong (#4971)

- added removing the leavingGroup atom from structure before serialisation if there is connection to monomer

* #4973 - Connection between molecule and monomer lost after opening and saving to ket

- fixed monomer atoms ids mapping during struct clone
- fixed removeLeavingGroupsFromConnectedAtoms
@rrodionov91 rrodionov91 mentioned this issue Jul 9, 2024
Closed
This was referenced Jul 29, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
bug
Projects
None yet
Milestone
Ketcher 2.22.0-rc.9
2 participants
@rrodionov91 @AlexeyGirin