Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backmerge: #4879 - Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong #4971

Merged

Conversation

rrodionov91
Copy link
Collaborator

@rrodionov91 rrodionov91 commented Jul 3, 2024

Also fix #4973 - Connection between molecule and monomer lost after opening and saving to ket

How the feature works? / How did you fix the issue?

  • added removing the leavingGroup atom from structure before serialisation if there is connection to monomer
  • fixed monomer atoms ids mapping during struct clone

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

…ected through attachment points works wrong

- added removing the leavingGroup atom from structure before serialisation if there is connection to monomer
@rrodionov91 rrodionov91 changed the title #4879 - Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong Backmerge: #4879 - Ketcher part: Save to mol for micro and macro structures connected through attachment points works wrong Jul 3, 2024
…d saving to ket

- fixed monomer atoms ids mapping during struct clone
Copy link
Collaborator

@AlexeyGirin AlexeyGirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@rrodionov91 rrodionov91 merged commit d994377 into master Jul 4, 2024
5 checks passed
@rrodionov91 rrodionov91 deleted the 4879-remove-leaving-group-during-conversion-indigo-master branch July 4, 2024 09:30
accmeboot pushed a commit that referenced this pull request Jul 5, 2024
…ctures connected through attachment points works wrong (#4971)

- added removing the leavingGroup atom from structure before serialisation if there is connection to monomer

* #4973 - Connection between molecule and monomer lost after opening and saving to ket

- fixed monomer atoms ids mapping during struct clone
- fixed removeLeavingGroupsFromConnectedAtoms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants