Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The user's choice is not saved in the settings, but is recalculated in px #5200

Closed
AnnaKosol opened this issue Aug 1, 2024 · 1 comment · Fixed by #5302
Closed

The user's choice is not saved in the settings, but is recalculated in px #5200

AnnaKosol opened this issue Aug 1, 2024 · 1 comment · Fixed by #5302

Comments

@AnnaKosol
Copy link
Collaborator

AnnaKosol commented Aug 1, 2024

Steps to Reproduce

  1. Go to the Settings
  2. Choose pt in the dropdown
    Снимок экрана 2024-08-01 в 11 09 21
  3. Click on Apply button
  4. Open the Settings again

Actual behavior
The parameters that we edited are specified in px.
Снимок экрана 2024-08-01 в 11 15 57

Expected behavior
The parameters that we edited are recalculated and indicated as we entered
Снимок экрана 2024-08-01 в 11 09 21


Need to add new fields to the JSON for the Settings
"fontszUnit": "px"
"fontszsubUnit": "px"
"bondThicknessUnit": "px"
"stereoBondWidthUnit": "px"

Environment details:
Ketcher Version 2.23.0-rc.3 Build at 2024-07-14; 20:34:10
Indigo Version 1.22.0-rc.3.0-gbb5c51fc2-wasm32-wasm-clang-19.0.0
Chrome Версия 126.0.6478.127 (Официальная сборка), (arm64)
MacOs Sonoma 14.5

rrodionov91 pushed a commit that referenced this issue Aug 16, 2024
…ated in px (#5302)

- added options to save selected measurement units
- updated to use enum for units & shapshot updates

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
@split-ends
Copy link
Collaborator

split-ends commented Sep 4, 2024

Successfully tested using different combinations of units: pt, cm, inch, px.
https://github.com/user-attachments/assets/25d5d78f-3580-4151-b586-0b020afece80

Environment details:
Ketcher Version: 2.25.0-rc.1 Build at 2024-09-03; 15:31:03
Indigo Version: 1.24.0-rc.1.0-gb8f099851-wasm32-wasm-clang-19.0.0
Chrome Version: Version 128.0.6613.113 (Official Build) (64-bit)
Windows 11 Enterprise

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
…ated in px (#5302)

- added options to save selected measurement units
- updated to use enum for units & shapshot updates

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants