#5200 – the users choice is not saved in the settings but is recalculated in px #5298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…choice-is-not-saved-in-the-settings-but-is-recalculated-in-px
rrodionov91
requested changes
Aug 15, 2024
| name, | ||
| className, | ||
| ...rest | ||
| }) => { | ||
| const [measure, setMeasure] = useState('px'); | ||
| const [measure, setMeasure] = useState( | ||
| extraValue || extraSchema?.default || 'px', |
There was a problem hiding this comment.
Can we use MeasurementUnits enum here instead of string literal?
| }; | ||
|
|
||
| useEffect(() => { | ||
| calcValue(); | ||
| }, [value, measure, calcValue]); | ||
| setCust(convertValue(value, 'px', measure)); |
There was a problem hiding this comment.
Can we use MeasurementUnits enum here instead of 'px'?
| @@ -71,18 +71,23 @@ class Form extends Component { | |||
| onUpdate(instance, valid, errs); | |||
| } | |||
|
|
|||
| field(name, onChange) { | |||
| field(name, onChange, extraName) { | |||
There was a problem hiding this comment.
Maybe rename 'extra' to something like 'second input name' or something that will describe it more clear?
accmeboot
deleted the
5200-the-users-choice-is-not-saved-in-the-settings-but-is-recalculated-in-px
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
(Screenshots, videos, or GIFs, if applicable)
Added 5 new properties to settings
Updated settings components to have extra schema and reflect the changes in it
Check list
#1234 – issue name