Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit Connection points dialog can cause invalid connection between monomers #5205

Closed
AlexeyGirin opened this issue Aug 1, 2024 · 1 comment · Fixed by #5717 or #5729
Closed

Edit Connection points dialog can cause invalid connection between monomers #5205

AlexeyGirin opened this issue Aug 1, 2024 · 1 comment · Fixed by #5717 or #5729
Assignees
@rrodionov91
Labels
Flex mode Bucket: Flex canvas related mode Priority: High Snake mode Bucket: Snake mode related issues
Milestone
Ketcher 2.26.0-rc.2

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Aug 1, 2024 •
edited
Loading

Steps to Reproduce

  1. Go to Macro mode
  2. Load from file using Add to Canvas way: Two nucleotides.zip
    image
  3. Open Edit Connection points dialog
    image
  4. Click on ALREADY selected connection points
  5. Press Reconnect button
  6. Open Edit Connection points dialog again

Actual behavior
image
All connection points are not selected.
More over - on the canvas - all connection points are available
image
image

Expected behavior
Two connection points are selected.
image

image

Versions

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.3.2-gb9ac1d93-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

Issues found while testing #4905
@AlexeyGirin AlexeyGirin added bug Priority: High Snake mode Bucket: Snake mode related issues Flex mode Bucket: Flex canvas related mode labels Aug 1, 2024
@AlexeyGirin AlexeyGirin changed the title Edit Connection points dialog can cause invalid connection between monoers Preview: Edit Connection points dialog can cause invalid connection between monoers Aug 1, 2024
@rrodionov91 rrodionov91 self-assigned this Oct 10, 2024
@rrodionov91 rrodionov91 changed the title Preview: Edit Connection points dialog can cause invalid connection between monoers Edit Connection points dialog can cause invalid connection between monomers Oct 10, 2024
rrodionov91 added a commit that referenced this issue Oct 10, 2024
@rrodionov91
#5205 - Edit Connection points dialog can cause invalid connection be…
ed9ddd8 
…tween monomers
@rrodionov91 rrodionov91 linked a pull request Oct 10, 2024 that will close this issue
#5205 - Edit Connection points dialog can cause invalid connection between monomers #5717
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 11, 2024
@rrodionov91
#5205 - Edit Connection points dialog can cause invalid connection be…
80f084a 
…tween monomers (#5717)

- fixed unstable test
rrodionov91 added a commit that referenced this issue Oct 11, 2024
@rrodionov91
#5205 - Edit Connection points dialog can cause invalid connection be…
a979aa3 
…tween monomers
@rrodionov91 rrodionov91 linked a pull request Oct 11, 2024 that will close this issue
Backmerge: #5205 - Edit Connection points dialog can cause invalid connection between monomers #5729
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Oct 13, 2024
@rrodionov91
#5205 - Edit Connection points dialog can cause invalid connection be…
eba3568 
…tween monomers
rrodionov91 added a commit that referenced this issue Oct 14, 2024
@rrodionov91
Backmerge: #5205 - Edit Connection points dialog can cause invalid co…
6fac9de 
…nnection between monomers (#5729)
@AlexeyGirin
Copy link
Collaborator Author

Verified.
image
image

  • Ketcher Version 2.26.0-rc.2 Build at 2024-10-14; 19:59:03
  • Indigo Toolkit Version 1.25.0-rc.2.0-g867ae250b-wasm32-wasm-clang-19.0.0
  • Chrome Version 129.0.6668.101 (Official Build) (64-bit)
  • Win10

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@rrodionov91 @Guch1g0v
Backmerge: #5205 - Edit Connection points dialog can cause invalid co…
c6cdde4 
…nnection between monomers (#5729)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rrodionov91 rrodionov91

Labels
Flex mode Bucket: Flex canvas related mode Priority: High Snake mode Bucket: Snake mode related issues
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
2 participants
@rrodionov91 @AlexeyGirin