Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a new name for the button ACS style #5561

Closed
AnnaKosol opened this issue Sep 23, 2024 · 1 comment · Fixed by #5721 or #5728
Closed

Set a new name for the button ACS style #5561

AnnaKosol opened this issue Sep 23, 2024 · 1 comment · Fixed by #5721 or #5728
Assignees
@KristinaKasyanovskaya
Labels
ACS standard feature request phase III Team G
Milestone
Ketcher 2.26.0-rc.2

Comments

@AnnaKosol
Copy link
Contributor

Background
related #5156 the button has been added

Solution
by agreement with @vanoprenko a new name for button should be "Set ACS Settings"
@AlexanderSavelyev AlexanderSavelyev added this to the Ketcher 2.26.0-rc.2 milestone Oct 7, 2024
Closed
9 tasks
@KristinaKasyanovskaya KristinaKasyanovskaya linked a pull request Oct 10, 2024 that will close this issue
#5561 Set a new name for the button acs style #5713
Closed
9 tasks
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 11, 2024
@KristinaKasyanovskaya
#5561-Set a new name for the button acs style (#5721)
7c1974d 
* fix:add new name

* test: add test
@NataliaLoginova NataliaLoginova linked a pull request Oct 11, 2024 that will close this issue
#5561-Set a new name for the button acs style #5721
Merged
9 tasks
@NataliaLoginova NataliaLoginova removed a link to a pull request Oct 11, 2024
#5561 Set a new name for the button acs style #5713
Closed
9 tasks
@NataliaLoginova NataliaLoginova linked a pull request Oct 11, 2024 that will close this issue
#5561 Set a new name for the button acs style #5713
Closed
9 tasks
Merged
9 tasks
@NataliaLoginova NataliaLoginova removed a link to a pull request Oct 15, 2024
#5561 Set a new name for the button acs style #5713
Closed
9 tasks
@NataliaLoginova NataliaLoginova linked a pull request Oct 15, 2024 that will close this issue
Backmerge: #5561 Set a new name for the button ACS style #5728
Merged
9 tasks
NataliaLoginova pushed a commit that referenced this issue Oct 18, 2024
@KristinaKasyanovskaya @AlexeyGirin
Backmerge: #5561 Set a new name for the button ACS style (#5728)
69e477a 
* fix: update button name

* test:update snapshot

* test: update screenshot

* test: update test

* test: update test

* test:update test

* test:update test

* test: update test mol-files

* test:update test for rnx-files

* test: udate test for sdf-files

* test:update test for acs-style-settings

* test:udate test for cdxml-files

* test:update test for cml-files

* test:update test for ket-files-properties

* test: update test for png-files

* test:update test for svg-files

* fix:fix test description

* test:update test

* test: update test case add delay

* test:update test

* test: fix test

* test: delete delay

* Small fix for autotest

* test:update test

---------

Co-authored-by: Alexey Girin <agirin@mail.ru>
@Zhirnoff
Copy link
Collaborator

Tested. Bug fixed.

2024-10-21_19h23_25

Desktop:

  • OS: Windows 11
  • Browser Chrome
  • Version 128.0.6613.120 (Official Build) (64-bit)

Ketcher version
[Version 2.26.0-rc.5]
Indigo version
[Version 1.25.0-rc.3]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KristinaKasyanovskaya KristinaKasyanovskaya

Labels
ACS standard feature request phase III Team G
Projects
None yet
Milestone
Ketcher 2.26.0-rc.2
7 participants
@AlexanderSavelyev @NataliaLoginova @accmeboot @AlexeyGirin @Zhirnoff @KristinaKasyanovskaya @AnnaKosol