Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new option in settings - "ACS Style" #5156

Closed
ljubica-milovic opened this issue Jul 23, 2024 · 2 comments · Fixed by #5492
Closed

Add new option in settings - "ACS Style" #5156

ljubica-milovic opened this issue Jul 23, 2024 · 2 comments · Fixed by #5492
Assignees
@AnnaKosol
Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.26.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 23, 2024 •
edited by AnnaKosol
Loading

Background
Just introducing all necessary settings that are needed to comply with ACS style is not enough. We should introduce a user-friendly way for the user to select ACS style.
A new section in the settings "ACS Style" should be added for that purpose.

Requirements

  1. A new option in setting should be added called "ACS Style"
    1.1. The button should be placed at the bottom of the settings modal window near buttons Cancel and Apply
    1.2 The button should be active all the time

  2. After clicking on the button "ACS Style", certain default values and units of measurement for following settings are chosen, and should be:

Setting Setting position "ACS Style" Unit of Measurement
Atom coloring General OFF
Font General Arial
Font size General 10 pt
Sub font size General 10 pt
Margin size (new setting) General 1,6 pt
Image resolution (new setting) General 600 ppi
Bond length (new setting) Bonds 14,4 pt
Bond spacing (old name: Double bond width) Bonds 18 % of width
Bond thickness Bonds 0,6 pt
Stereo (Wedge) bond width Bonds 2 pt
Hash spacing (new setting) Bonds 2,5 pt
  1. When clicking on the button "ACS Style" -> Apply at the bottom of the window -> clicking on layout, positions of all elements on the canvas are recalculated so that they comply with "ACS Style".
  2. The settings return to default after clicking on Reset.
@AnnaKosol AnnaKosol added Team G Test Cases Written Test cases has been written for that issue and removed Test Cases Written Test cases has been written for that issue labels Jul 25, 2024
@AnnaKosol AnnaKosol added the Test Cases Written Test cases has been written for that issue label Jul 26, 2024
@AnnaKosol
Copy link
Collaborator

To solve this task, it is necessary to implement #5175 and #5176

@AnnaKosol AnnaKosol removed the Test Cases Written Test cases has been written for that issue label Aug 1, 2024
@ljubica-milovic ljubica-milovic changed the title Add new section in settings - "Visual representation" Add new option in settings - "Visual representation" Aug 1, 2024
@ljubica-milovic ljubica-milovic changed the title Add new option in settings - "Visual representation" Add new option in settings - "ACS Style" Aug 1, 2024
@AnnaKosol AnnaKosol added the Test Cases Written Test cases has been written for that issue label Aug 7, 2024
@accmeboot accmeboot self-assigned this Sep 5, 2024
accmeboot pushed a commit that referenced this issue Sep 6, 2024
#5156 - added new options and field
bdcf2ce
accmeboot pushed a commit that referenced this issue Sep 10, 2024
#5156 -- removed the popup & added acs style button that updates the …
89c721f 
…fromState
@accmeboot accmeboot linked a pull request Sep 11, 2024 that will close this issue
#5156 - add new option in settings acs style #5492
Merged
9 tasks
accmeboot pushed a commit that referenced this issue Sep 11, 2024
#5156 -- options schema clean up
4f23388
accmeboot pushed a commit that referenced this issue Sep 12, 2024
#5156 -- autotests update
9f3b31f
rrodionov91 pushed a commit that referenced this issue Sep 17, 2024
@accmeboot
#5156 - add new option in settings acs style (#5492)
e892013 
* #5156 - added new options and field

* #5156 -- removed the popup & added acs style button that updates the fromState

* #5156 -- options schema clean up

* #5156 -- autotests update

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
@AnnaKosol AnnaKosol mentioned this issue Sep 23, 2024
Closed
@AnnaKosol
Copy link
Collaborator

Image

Verified - a new option is added and all settings are with right parameters.

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @Guch1g0v
#5156 - add new option in settings acs style (#5492)
239c343 
* #5156 - added new options and field

* #5156 -- removed the popup & added acs style button that updates the fromState

* #5156 -- options schema clean up

* #5156 -- autotests update

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaKosol AnnaKosol

Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.26.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5156 - add new option in settings acs style epam/ketcher
4 participants
@accmeboot @ljubica-milovic @AnnaKosol @AlekseiKhariukov