Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow entering values in settings with the precision of one decimal place #5175

Closed
ljubica-milovic opened this issue Jul 26, 2024 · 3 comments · Fixed by #5423
Closed

Allow entering values in settings with the precision of one decimal place #5175

ljubica-milovic opened this issue Jul 26, 2024 · 3 comments · Fixed by #5423
Assignees
@AnnaKosol
Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Milestone
Ketcher 2.26.0-rc.1

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 26, 2024 •
edited
Loading

Background
Currently, for certain settings (Font size, Double bond width etc.) the user is able to choose one of two units of measurement (pt and px). Values that can be entered are only integers. To better comply with ACS standard (where certain values in pt have decimals) and to make behaviors for cm, in, pt, and px more consistent, the user should be able to enter/view values with the precision of one decimal place regardless of the unit of measurement.

Solution

  1. All old and new settings (Related issue: #5152) (except "Rotation Step, º" and "Bond spacing" (the old name of this setting is "Double bond width" Related issue: #5154) that require a number input should allow entering values for pt/px with one decimal place.
  2. When switching to cm/in the user should see a value with one decimal place (currently it is three).
@AnnaKosol AnnaKosol mentioned this issue Jul 29, 2024
Closed
@AnnaKosol AnnaKosol added phase III Team G Test Cases Written Test cases has been written for that issue labels Aug 1, 2024
@ljubica-milovic ljubica-milovic changed the title Allow entering values in settings with the precision of three decimal places (pt and px) Allow entering values in settings with the precision of one decimal place Aug 5, 2024
@AnnaKosol AnnaKosol added Test Cases Written Test cases has been written for that issue and removed Test Cases Written Test cases has been written for that issue labels Aug 5, 2024
@AnnaKosol AnnaKosol mentioned this issue Aug 22, 2024
Closed
@AlexeyGirin
Copy link
Collaborator

ACS-StyleGuide.pdf

accmeboot pushed a commit that referenced this issue Sep 3, 2024
#5175 - fontsz float
4896b23
accmeboot pushed a commit that referenced this issue Sep 3, 2024
#5175 -- added float value validation
2eea75b
@accmeboot accmeboot linked a pull request Sep 3, 2024 that will close this issue
#5175 - allow entering values in settings with the precision of one decimal place #5423
Merged
9 tasks
@AnnaKosol
Copy link
Collaborator

It is not possible to enter a value less than one

Steps:

  1. type 0
  2. after that type point

Actual result: nothing happened and only 0 is displayed

Expected result: 0.1 is displayed in the field

accmeboot pushed a commit that referenced this issue Sep 6, 2024
#5175 - fontsz float
4718e96
accmeboot pushed a commit that referenced this issue Sep 6, 2024
#5175 -- added float value validation
9a79db7
accmeboot pushed a commit that referenced this issue Sep 6, 2024
#5175 -- the < 1 entry bugfix & updated max default values for the ne…
0ad9fed 
…w fields
accmeboot pushed a commit that referenced this issue Sep 6, 2024
#5175 - float min value fix
76b970e
rrodionov91 pushed a commit that referenced this issue Sep 11, 2024
@accmeboot
#5175 - allow entering values in settings with the precision of one d…
4bc7ab6 
…ecimal place (#5423)

- fontsz float
- added float value validation
- the < 1 entry bugfix & updated max default values for the new fields
- float min value fix

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
@AnnaKosol
Copy link
Collaborator

Verified

Environment
https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
Ketcher Version 2.26.0-rc.1 Build at 2024-10-04; 18:45:04
Indigo Version 1.25.0-rc.1.0-g704673fcb-wasm32-wasm-clang-19.0.0
MacOs
Chrome 129.0.6668.71 (Official Build) (arm64)

Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @Guch1g0v
#5175 - allow entering values in settings with the precision of one d…
8ed41e7 
…ecimal place (#5423)

- fontsz float
- added float value validation
- the < 1 entry bugfix & updated max default values for the new fields
- float min value fix

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnnaKosol AnnaKosol

Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Ketcher 2.26.0-rc.1
Development

Successfully merging a pull request may close this issue.

#5175 - allow entering values in settings with the precision of one decimal place epam/ketcher
4 participants
@AlexeyGirin @ljubica-milovic @AnnaKosol @AlekseiKhariukov