Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Double bond width" setting #5154

Closed
ljubica-milovic opened this issue Jul 23, 2024 · 1 comment · Fixed by #5394
Closed

Change "Double bond width" setting #5154

ljubica-milovic opened this issue Jul 23, 2024 · 1 comment · Fixed by #5394
Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue

Comments

@ljubica-milovic
Copy link
Collaborator

ljubica-milovic commented Jul 23, 2024 •
edited by accmeboot
Loading

Background
Currently the setting "Double bond width" is similar to others (user can choose cm/px/pt/in):
image

Requirements

  1. To better reflect ACS style the setting should be renamed to "Bond spacing", because it impacts not only the double bond.
  2. The user shouldn't be able to choose cm/px/pt/in but a percentage of the bond length -
    added here: 5152
    ACS standard:
    image
  3. Current value as a percentage of bond width should be determined.

field in the Setting should be bondSpacing

UX
Image
@ljubica-milovic ljubica-milovic mentioned this issue Jul 23, 2024
Closed
@AnnaKosol AnnaKosol added Team G Test Cases Written Test cases has been written for that issue labels Jul 25, 2024
This was referenced Aug 1, 2024
Closed
Closed
This was referenced Aug 16, 2024
Closed
Closed
accmeboot pushed a commit that referenced this issue Aug 28, 2024
#5154 -- bond spacing instead of double bond width
d5c1038
@accmeboot
Copy link
Collaborator

accmeboot commented Aug 29, 2024 •
edited
Loading

The default bond length is 40 so the bondSpacing should remain the same value as before - 6px.
The default should be 15%.

accmeboot pushed a commit that referenced this issue Aug 29, 2024
#5154 -- applied valid default values
c548201
accmeboot pushed a commit that referenced this issue Aug 29, 2024
#5154 -- input className fix for unit tests
8045663
@accmeboot accmeboot linked a pull request Aug 29, 2024 that will close this issue
#5154 -- Change "Double bond width" setting #5394
Merged
9 tasks
accmeboot pushed a commit that referenced this issue Aug 29, 2024
#5154 -- autotests screenshots updated with new default values
128f2b4
accmeboot pushed a commit that referenced this issue Sep 2, 2024
#5154 -- conflict fix
2cf8692
accmeboot pushed a commit that referenced this issue Sep 3, 2024
#5154 -- bond spacing instead of double bond width
0a46b83
accmeboot pushed a commit that referenced this issue Sep 3, 2024
#5154 -- applied valid default values
e855163
accmeboot pushed a commit that referenced this issue Sep 3, 2024
#5154 -- input className fix for unit tests
b0c669b
accmeboot pushed a commit that referenced this issue Sep 4, 2024
#5154 - autotests fix
8719224
rrodionov91 pushed a commit that referenced this issue Sep 4, 2024
@accmeboot
#5154 - Change "Double bond width" setting (#5394)
ba87253 
- bond spacing instead of double bond width
- applied valid default values
- autotests screenshots updated with new default values

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Guch1g0v pushed a commit that referenced this issue Oct 17, 2024
@accmeboot @Guch1g0v
#5154 - Change "Double bond width" setting (#5394)
261e4dd 
- bond spacing instead of double bond width
- applied valid default values
- autotests screenshots updated with new default values

---------

Co-authored-by: Mikhail Vialov <mikhail_vialov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ACS standard feature request phase III Team G Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#5154 -- Change "Double bond width" setting epam/ketcher
4 participants
@accmeboot @ljubica-milovic @AnnaKosol @AlekseiKhariukov