Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to save information about the coordinates of the Stereo flags in * .ket #559

Closed
Svetlana-Asinovskaia opened this issue Jun 2, 2021 · 3 comments · Fixed by #600

Comments

@Svetlana-Asinovskaia
Copy link
Collaborator

Svetlana-Asinovskaia commented Jun 2, 2021

  1. User creates a structure on the canvas, adds a stereobond (stereo flag appears next to the structure), saves the structure in ket.
    Result: As user hasn't moved the stereo flag the information about the coordinates is not present in ket file and their values are set by default.

  2. User creates a structure on the canvas, adds a stereobond (stereo flag appears next to the structure), moves the stereo flag (to a new position or it is returned to the initial position after being moved), saves the structure in ket.
    Result: Stereo flag coordinates are present in ket file. After opening the saved file the stereo flag appears at the position in which it was before saving.

@Svetlana-Asinovskaia
Copy link
Collaborator Author

Svetlana-Asinovskaia commented Jun 4, 2021

Check the following scenario of overlapping the Stereo flag with a structure:

  1. Launch Ketcher.
  2. Create a benzene molecule using the Templates tool.
  3. Add a stereo bond (e.g. Single Up bond) to the following carbon atom:
    image
  4. Add another stereo bond to the following carbon atom:
    image

Expected result: Stereo flag is not overlapped with a structure.
Actual result: Stereo flag is overlapped with a structure.

@AndreiMazol AndreiMazol linked a pull request Jun 18, 2021 that will close this issue
AndreiMazol added a commit that referenced this issue Jun 18, 2021
* update ket file structure

* add flag position to schema.json

* save stereo flag position

* update logic to calculate stereo flag position
@AleksandrPokrovskii
Copy link
Contributor

Stereo flag is overlapped with a structure.

  1. Launch Ketcher.
  2. Create a benzene molecule using the Templates tool.
  3. Add a stereo bond (e.g. Single Up bond) to the following carbon atom:
    image

3)Add a single bond to the following carbon atom:
image

Expected result: Stereo flag is not overlapped with a structure.
Actual result: Stereo flag is overlapped with a structure.

@AndreiMazol
Copy link
Contributor

It will be fixed in scope of a separate issue: #602
cc: @AleksandrPokrovskii

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants