Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Representation of Stereo Flags #57

Closed
Vesdet opened this issue Oct 12, 2020 · 5 comments · Fixed by #423
Closed

Representation of Stereo Flags #57

Vesdet opened this issue Oct 12, 2020 · 5 comments · Fixed by #423
Assignees
@AndreiMazol @Svetlana-Asinovskaia
Labels
enhancement epic: enhanced stereochemistry
Milestone
Release 2.3.0

Comments

@Vesdet
Copy link
Contributor

Vesdet commented Oct 12, 2020 •
edited by Svetlana-Asinovskaia
Loading

The following behavior should be implemented to Stereo Flags:

  1. As soon as correct stereocenter appears on canvas, Stereo Flag should appear above the structure at the right side.
    StereoFlags1
  2. Stereo Flags should't appear for structures without correct stereocenters, for example:
    StereoFlags2
  3. User should be able to move Stereo Flag to any place on canvas, using any Selection Tool.
  4. Stereo Flag shouldn’t be overlapped with the structure.
  5. User should not be able to delete Stereo Flags, using 'Erase' button or 'Delete' button on keyboard.
  6. Stereo Flags for reactions. When reagents and products have stereocenters, Stereo Flags should appear above the corresponding structures at the right side of each structure having stereocenter. See the example:
    StereoFlags3
  7. Stereo Flags that were saved in reactions should be rendered correctly. See the example of incorrect rendering Stereo Flags.
    StereoFlags4
    Epic link: [EPIC] Enhanced Stereochemistry #56
@Vesdet Vesdet added this to the Enhanced Stereochemistry milestone Oct 12, 2020
@Vesdet Vesdet mentioned this issue Oct 12, 2020
Closed
@AndreiMazol AndreiMazol assigned ensemenova and unassigned ensemenova Mar 17, 2021
@ensemenova ensemenova self-assigned this Mar 22, 2021
@ensemenova
Copy link
Contributor

After discussion with @AlexanderSavelyev point 2 was separated to new issue #418

ensemenova added a commit that referenced this issue Mar 24, 2021
@ensemenova
Merge branch 'master' into #57-stereoflags-on-reaction
dc604ce 
# Conflicts:
#	packages/ketcher-react/src/script/render/restruct/ReEnhancedFlag.ts
#	packages/ketcher-react/src/script/render/restruct/ReSimpleObject.ts
#	packages/ketcher-react/src/script/render/restruct/index.js
#	packages/ketcher-standalone/src/generated/libindigo.js
@ensemenova ensemenova linked a pull request Mar 25, 2021 that will close this issue
#57 fix stereoflags on reaction + refactor #423
Merged
ensemenova added a commit that referenced this issue Mar 30, 2021
@ensemenova
Merge remote-tracking branch 'origin/master' into #57-stereoflags-on-…
048be89 
…reaction
@AndreiMazol AndreiMazol modified the milestones: Enhanced Stereochemistry, Release 2.3.0 Apr 21, 2021
@Svetlana-Asinovskaia
Copy link
Collaborator

Svetlana-Asinovskaia commented May 13, 2021 •
edited
Loading

  1. The problem with incorrect rendering of Stereo Flags in reactions is still reproduced and it was described in the comments for the issue Incorrect rendering of Stereo Flags in reactions #58.
  2. User is not able to delete Stereo Flags, using the 'Erase' tool or the 'Delete' button on a keyboard.
    2021-05-13_16h13_47

Update (31/05/2021) Comment 2. is invalid as the requirements have been changed. User shouldn't be able to delete Stereo Flags.

@AndreiMazol
Copy link
Contributor

AndreiMazol commented May 31, 2021 •
edited by Svetlana-Asinovskaia
Loading

@AndreiMazol AndreiMazol assigned AndreiMazol and unassigned ensemenova Jun 2, 2021
@AndreiMazol
Copy link
Contributor

All ACs have been implemented in scope of other issues.

@Svetlana-Asinovskaia
Copy link
Collaborator

Release/2.3 The issue is verified and closed. The problem with overlapping the stereo flags in the cyclic structures is OOS and will be fixed in #559
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@Svetlana-Asinovskaia Svetlana-Asinovskaia

Labels
enhancement epic: enhanced stereochemistry
Projects
None yet
Milestone
Release 2.3.0
Development

Successfully merging a pull request may close this issue.

#57 fix stereoflags on reaction + refactor epam/ketcher
4 participants
@Vesdet @AndreiMazol @ensemenova @Svetlana-Asinovskaia